Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LFO display doesn't update when automating LFO controls #6849

Closed
VincyZed opened this issue Feb 18, 2023 · 1 comment · Fixed by #6857
Closed

LFO display doesn't update when automating LFO controls #6849

VincyZed opened this issue Feb 18, 2023 · 1 comment · Fixed by #6857
Labels
Bug Report Item submitted using the Bug Report template Host Automation Issues related to DAW (host) automation UI Issues related to UI look&feel
Milestone

Comments

@VincyZed
Copy link
Collaborator

The LFO display doesn't update when automating any or multiple LFO controls.

Switching to another LFO and switching back forces it to repaint and it updates to the current state, but still stays static. Moving the sliders manually though updates fine of course.

Paul: "Bet MIDI CC does the same"

@VincyZed VincyZed added UI Issues related to UI look&feel Bug Report Item submitted using the Bug Report template labels Feb 18, 2023
@VincyZed VincyZed added this to the Surge XT 1.2 milestone Feb 18, 2023
@mkruselj mkruselj added the Host Automation Issues related to DAW (host) automation label Feb 18, 2023
@mkruselj
Copy link
Collaborator

mkruselj commented Feb 24, 2023

For LFO, I can see this:

image

So there's no attempts to repaint at all when this method is called (and it's called in SGE L927 and L1009 ).

Comparing with oscillator display, the similarly named repaintIfIdIsInRange actually does something. So we just need to apply the same methodology for the LFO display. On it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template Host Automation Issues related to DAW (host) automation UI Issues related to UI look&feel
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants