Ring Modultor Unison not modulatable

[baconpaul]

the RM FX detune isn't modulatable

The reason for this is

if (fxdata->p[rm_unison_detune].absolute)
        {
            dphase[u] = (storage->note_to_pitch(*f[rm_carrier_freq]) * Tunings::MIDI_0_FREQ +
                         fxdata->p[rm_unison_detune].get_extended(
                             fxdata->p[rm_unison_detune].val.f * detune_offset[u])) *
                        sri;
        }
        else
        {
            dphase[u] =
                storage->note_to_pitch(*f[rm_carrier_freq] +
                                       fxdata->p[rm_unison_detune].get_extended(
                                           fxdata->p[rm_unison_detune].val.f * detune_offset[u])) *
                Tunings::MIDI_0_FREQ * sri;
        }

We use fxdata->p[].get_extended which is fine but use it in fxdata->p[].val.f which is the value, not the modulated value.

Replace that with

 storage->note_to_pitch(*f[rm_carrier_freq] +
                                       fxdata->p[rm_unison_detune].get_extended(
                                           *f[rm_unison_detune] * detune_offset[u]))

in both places.

[mkruselj]

Oh cool, I can take care of that.