Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Oneshot mode to the LFO #6692

Open
mkruselj opened this issue Nov 5, 2022 · 5 comments
Open

Add Oneshot mode to the LFO #6692

mkruselj opened this issue Nov 5, 2022 · 5 comments
Labels
Feature Request New feature request Modulation Modulation related issues
Milestone

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Nov 5, 2022

We definitely have enough room above the Unipolar button for a Oneshot button. It would pertain only to the LFO and not the EG - basically play one single LFO cycle then freeze the LFO output at the last played value. This is something that Shortcircuit's LFOs have, too, so it'd bring nice parity between the two.

@mkruselj mkruselj added Feature Request New feature request Modulation Modulation related issues labels Nov 5, 2022
@mkruselj mkruselj added this to the Surge XT 1.1.3 milestone Nov 5, 2022
@Andreya-Autumn
Copy link
Collaborator

Solid idea. If I understand that right it'd make the S&H LFO shape behave just like the Random modulator yeah?

What'd the noise LFO shape do then? Random walk until reaching the time set by the rate knob I guess? That could be a really cool function, but to really reach full potential it would require a way to control the rate of the random walking separately from the amount of time before the "cycle" is over. Hmm...

@Andreya-Autumn
Copy link
Collaborator

And it only makes sense in keytrigger mode also right? At least I can't think what such a function would do in freerun mode?

So maybe simplest initial implementation is: The option is greyed out when selecting other combinations for which it makes no sense. Which might be freerun mode, possibly S&H because redundant, and Noise because requires parameter trickery. Aksi sequencer and formula because like, what?

@mkruselj
Copy link
Collaborator Author

mkruselj commented Nov 5, 2022

Yeah S&H would behave like Random modulator. And it would basically behave the same in all the trigger modes, I don't think it needs to be grayed out in modes other than Keytrigger (that actually makes the implementation more complicated 😛 ). Noise LFO would be like S&H but it would be smoothed between phase cycles I reckon (because that's all the Noise LFO is - a cubic interpolated S&H). Step sequencer would also be entirely valid - plays the sequence once then stops at last step - loop wouldn't be played. Formula is also valid if it generates a cyclical thing, I'd suspect.

@Andreya-Autumn
Copy link
Collaborator

Ah ok, that makes sense about the noise LFO and step seq shapes.

I'm not sure I see the point in freerun mode though. Wouldn't that just mean it'd do one cycle when pressing play and then never again? That doesn't seem super useful? Or am I missing something?

@mkruselj
Copy link
Collaborator Author

mkruselj commented Nov 6, 2022

I guess we can cross-reference the behavior with Shortcircuit, ultimately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature request Modulation Modulation related issues
Projects
None yet
Development

No branches or pull requests

2 participants