Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider End Binary Distro of LV2 #6605

Closed
baconpaul opened this issue Sep 10, 2022 · 9 comments
Closed

Consider End Binary Distro of LV2 #6605

baconpaul opened this issue Sep 10, 2022 · 9 comments
Labels
Bug Report Item submitted using the Bug Report template LV2 Issues related to the LV2 ports of Surge
Milestone

Comments

@baconpaul
Copy link
Collaborator

baconpaul commented Sep 10, 2022

The LV2 with the community fork has several bugs. We keep getting reports like this:

Screen Shot 2022-09-10 at 11 01 01 AM

so lets stop the binary distribution of it at least, since it seems with juce 7 the community juce 6 fork is no longer actively maintained.

@baconpaul baconpaul added the Bug Report Item submitted using the Bug Report template label Sep 10, 2022
@baconpaul baconpaul added this to the Surge XT 1.1.x milestone Sep 10, 2022
@haenkel
Copy link
Contributor

haenkel commented Sep 11, 2022

Not enough time to create anything pullrequestworthy
but I quickly tried something and thought I'd share it.
If I do something like this:
haenkel@899bacb
then patches seem to (re)load correctly in all formats for me.
(haven't tried ardour but same happens in reaper)

@baconpaul
Copy link
Collaborator Author

So that just forced things to load twice right?

@haenkel
Copy link
Contributor

haenkel commented Sep 12, 2022

simplified the above example
but yes it does that

@mkruselj mkruselj added the LV2 Issues related to the LV2 ports of Surge label Sep 12, 2022
@dvzrv
Copy link

dvzrv commented Oct 16, 2022

so lets stop the binary distribution of it at least, since it seems with juce 7 the community juce 6 fork is no longer actively maintained.

JUCE 7 has native support for lv2 :)

@baconpaul
Copy link
Collaborator Author

Yes I know. It doesn't seem to work quite properly for us when we check in the hosts that support it; but also we are on juce 6 still!

@baconpaul
Copy link
Collaborator Author

or more accurately: a version of juce 6 with some accessibility patches which are critical so moving is a pain.

you can build surge today with juce 7 if you want and get an lv2. this is just about whether we should continue to ship a binary built with the community build.

@mkruselj
Copy link
Collaborator

JUCE 7 has native support for lv2 :)

Yep and LV2 produced by JUCE 7 doesn't work in Reaper, for example.

@baconpaul
Copy link
Collaborator Author

meh lets not change anything for 1.2

@baconpaul baconpaul modified the milestones: Surge XT 1.2, Surge XT 1.x Jan 9, 2023
@mkruselj mkruselj modified the milestones: Surge XT 1.x, Surge XT 1.2.1 Apr 5, 2023
@baconpaul
Copy link
Collaborator Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template LV2 Issues related to the LV2 ports of Surge
Projects
None yet
Development

No branches or pull requests

4 participants