Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DisplayInfo #632

Closed
baconpaul opened this issue Feb 20, 2019 · 1 comment
Closed

Remove DisplayInfo #632

baconpaul opened this issue Feb 20, 2019 · 1 comment
Labels
Bug Report Item submitted using the Bug Report template Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme JUCE Ex Machina Issue that will likely be fixed by porting Surge to JUCE UI/plugin back-end Linux Issues which only occur on Linux
Milestone

Comments

@baconpaul
Copy link
Collaborator

baconpaul commented Feb 20, 2019

Once we are on Juce no need for DisplayInfo

  1. The backingstore depth won't be used any more
  2. and juce::Display has everything we need

so eliminate this code completely rather than doing the fix below.

(was)
Right now, DisplayInfoMac and DIsplayInfoWin use the frame passed to them to find the display of the window and return the size of that window, meaning "max" works appropriately on multi-element displays. On Linux we don't do that; rather we just use the dimensions of the primary display. This means "max" works inconsistently on multi-display linux systems.

When @baconpaul wrote the rough cut of display size he commented this; @tank-trax later discovered it on his multi-monitor linux system.

@baconpaul baconpaul added the Linux Issues which only occur on Linux label Feb 20, 2019
@baconpaul baconpaul added this to the 1.7 or later milestone Feb 24, 2019
@baconpaul baconpaul modified the milestones: 1.7 or later, Currently Unscheduled Oct 4, 2019
@mkruselj mkruselj added the Bug Report Item submitted using the Bug Report template label Nov 9, 2020
@mkruselj mkruselj added the JUCE Ex Machina Issue that will likely be fixed by porting Surge to JUCE UI/plugin back-end label Jan 21, 2021
@baconpaul baconpaul changed the title Linux Screen Detection with Multiple Monitors Remove DisplayInfo Apr 16, 2021
@baconpaul baconpaul added the Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme label Apr 16, 2021
@baconpaul
Copy link
Collaborator Author

hey this is done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme JUCE Ex Machina Issue that will likely be fixed by porting Surge to JUCE UI/plugin back-end Linux Issues which only occur on Linux
Projects
None yet
Development

No branches or pull requests

2 participants