Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

125x images have mis-aligned background #612

Closed
baconpaul opened this issue Feb 15, 2019 · 6 comments
Closed

125x images have mis-aligned background #612

baconpaul opened this issue Feb 15, 2019 · 6 comments

Comments

@baconpaul
Copy link
Collaborator

@itsmedavep seems the 125x image has the background mis-aligned

Here's linux zoomed to 125. Windows does the same.

I didn't catch it because on mac with my retina display 125 == 250 so it uses the 300 asset

image

can you check and re-export the 125 images when you get a chance? We can sweep immediately when you do.

Thanks.

@baconpaul
Copy link
Collaborator Author

Hi @itsmedavep I turned off 125x in the builds for now so the urgency is less. When you get a chance!

Sort of need to do a code change and a windows or linux build to test it.

@itsmedavep
Copy link
Contributor

Obviously that’s busted. Ouch.

I’m not near a machine right now but I’ll take a look when I get close to one. Should be in an hour.

@itsmedavep
Copy link
Contributor

Sorry BTW!

@itsmedavep
Copy link
Contributor

#618

@baconpaul
Copy link
Collaborator Author

No need to apologize! Sorry my testing skipped it! It was only in master for 40 minutes so no big deal at all!!

@baconpaul
Copy link
Collaborator Author

Hi! So @esaruoho @itsmedavep and I are working on a different way to deal with 125x images (and for that matter all images) so I'm going to close this issue for now in anticipation of our approach working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants