Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune button unexpectedly toggles when dragging tab-group selectors #5852

Closed
j5v opened this issue Jan 31, 2022 · 3 comments
Closed

Tune button unexpectedly toggles when dragging tab-group selectors #5852

j5v opened this issue Jan 31, 2022 · 3 comments
Labels
Bug Report Item submitted using the Bug Report template UI Issues related to UI look&feel

Comments

@j5v
Copy link
Contributor

j5v commented Jan 31, 2022

Bug Description:

Surge XT Version
Version: Surge XT 1.1.nightly.eb7be88
Build: 2022-01-31 @ 20:22:31 on 'WIN-TH67P0TFHGU/pipeline' with 'MSVC-19.29.30139.0' using JUCE 6.1.2
System: Windows 64-bit Standalone on Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
Sample Rate: 44.1 kHz

Reproduction Steps:
Steps to reproduce the behavior - cases:

  1. Click and hold the OSC 1 select button, and then drag the mouse.
    The accessibility focus (blue) highlights the OSC 3 selector, and Tune toggles on and off.

  2. If you click and hold the Filter 1 (or Filter 2) icon for filter type, and drag up and down to change filter type, then in addition to the expected functionality, Tune toggles on and off.

Expected Behavior:
Tune should not toggle with these UI actions.

Additional Information:
.

@j5v j5v added the Bug Report Item submitted using the Bug Report template label Jan 31, 2022
@mkruselj
Copy link
Collaborator

mkruselj commented Feb 1, 2022

Probably a duplicate or closely related to #5801.

@mkruselj mkruselj added the UI Issues related to UI look&feel label Feb 1, 2022
@j5v
Copy link
Contributor Author

j5v commented Feb 1, 2022

The appearance of the blue label is - I remember discussing that in Discord, for pre-XT1.0, just after the main accessibility/keyboard changes. The Tune button being highlighted is (guess) probably group/component IDs.

@mkruselj
Copy link
Collaborator

This seems fixed now, as a consequence of fixing #5801.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template UI Issues related to UI look&feel
Projects
None yet
Development

No branches or pull requests

2 participants