Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up SurgeParamConfig.h #5749

Open
mkruselj opened this issue Jan 10, 2022 · 0 comments
Open

Clean up SurgeParamConfig.h #5749

mkruselj opened this issue Jan 10, 2022 · 0 comments
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme Skinning Engine Issues related to Surge's skin engine UI Issues related to UI look&feel
Milestone

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Jan 10, 2022

For XT 2.0, we should strive to chuck out the last UI-to-engine bindings that are in SurgeParamConfig.h.

Additionally, clean up the relevant SVGs so that they don't have multiple things crammed in them that we then get to by offsetting frames. For example, the pitch slider has those extra notches for semitones. This should be a new component class in the skin definition itself, rather than taking bmp00154, row 3.

.asWhite should also just disappear as a consequence. Again just a new component class.

LFO EG sliders being smaller in height than other vertical sliders. Again just a new component class. It has no place being in bmp00105. (But this gets sorted out in the GUI redesign by and large, though.)

Unipolar vs bipolar slider variants? Same exact thing. One SVG per slider "type".

What does make sense is keeping the variants as frames, so - empty, has modulation assigned but not from currently selected modulator, modulation being assigned from current modulator - those should stay in the SVG.

@mkruselj mkruselj added Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme UI Issues related to UI look&feel Skinning Engine Issues related to Surge's skin engine labels Jan 10, 2022
@mkruselj mkruselj added this to the Surge XT 2.0 milestone Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme Skinning Engine Issues related to Surge's skin engine UI Issues related to UI look&feel
Projects
None yet
Development

No branches or pull requests

1 participant