Clean up SurgeParamConfig.h #5749
Labels
Code Refactoring
General code refactoring and cleanup issues like names, unused variables, warnings, fixme
Skinning Engine
Issues related to Surge's skin engine
UI
Issues related to UI look&feel
Milestone
For XT 2.0, we should strive to chuck out the last UI-to-engine bindings that are in
SurgeParamConfig.h
.Additionally, clean up the relevant SVGs so that they don't have multiple things crammed in them that we then get to by offsetting frames. For example, the pitch slider has those extra notches for semitones. This should be a new component class in the skin definition itself, rather than taking
bmp00154
, row 3..asWhite
should also just disappear as a consequence. Again just a new component class.LFO EG sliders being smaller in height than other vertical sliders. Again just a new component class. It has no place being in
bmp00105
. (But this gets sorted out in the GUI redesign by and large, though.)Unipolar vs bipolar slider variants? Same exact thing. One SVG per slider "type".
What does make sense is keeping the variants as frames, so - empty, has modulation assigned but not from currently selected modulator, modulation being assigned from current modulator - those should stay in the SVG.
The text was updated successfully, but these errors were encountered: