Global distorsion effect is not loaded correctly

[hsn10]

Bug Description:
After loading my saved patch there is no sound. It looks like it is caused by global distorsion effect not initializing correctly.

Surge Version

• Version: 190
• Plugin Type: VST3
• Bitness: 64-bit

Reproduction Steps:
Steps to reproduce the behavior:

1. Load attached patch
2. There should be sound but I hear only clicking

Expected Behavior:
Loading patch should sound the same as patch sounded at the time it got saved.

Computer Information:

• OS: Windows 10
• Host: Cakewalk

Distored Guitar.zip

[baconpaul]

There’s a bug in 19 if you use waveshapers other than soft and hard which we fixed in xt. I haven’t looked at patch yet but wonder if that’s the case here

[hsn10]

Patch is using waveshaper hard. It looks like initialization problem, values for distorsion are loaded back from file correctly.

[baconpaul]

The patch you shared has the wave shaper set to "Sine" which was one of the wave shaper setups we fixed

I checked your patch and it loaded in XT (the beta version now ready for release in January). The commit that fixed it was 553e04c

So I think this is fixed in the new version. Any chance you'd be interested in trying the beta? IF not, changing from 'sine' to 'hard' in the 'model' dropdown, saving, and restarting your daw should fix it with 1.9

[baconpaul]

oh and the wavehsaper in question here is the one in the 'model' param of the distortion, not the wave shaper in the filter section, just FYI

[hsn10]

You plan to fix 1.9 line? I don't want to install new version to mess up presets.

[mkruselj]

We won't be returning to 1.9 anymore. At any rate Surge XT installs side by side so none of your patches will be affected.

[baconpaul]

but also you can just change the model from 'sine' to 'hard' in your distortion preset and everything will work.

[mkruselj]

Closing as fixed in XT.