Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VKB sticks if you open a menu #5480

Open
baconpaul opened this issue Nov 25, 2021 · 6 comments
Open

VKB sticks if you open a menu #5480

baconpaul opened this issue Nov 25, 2021 · 6 comments
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.

Comments

@baconpaul
Copy link
Collaborator

Press a key
Open a menu
Voila, no way to release other than down/up again
Tricky....

@baconpaul baconpaul added the Bug Report Item submitted using the Bug Report template label Nov 25, 2021
@baconpaul baconpaul added this to the Surge XT 1.0 milestone Nov 25, 2021
@mkruselj mkruselj added the UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. label Nov 25, 2021
@baconpaul
Copy link
Collaborator Author

OK here's how it is now

Press key
Release key
Works

Press Key
Open Menu
Close Menu
Release key
Works

Press Key
Open Menu
Release Key
Close Menu
Note sticks

Press Key
Open Menu
Release Key
Close Menu
Press Key (nothing happens)
Release Key
Note Releases

So that middle case is really the hard one

May be too hard to fix also. Debating. And not entirely clear what the fix is to me right now.

@mkruselj
Copy link
Collaborator

Another possibly related behavior:

  1. Enable keyboard shortcuts
  2. Press Alt/Option and hold it
  3. Press K and shortly hold it - VKB opens
  4. Right after you pressed K release Alt/Option while K is still held - a note is played matching the K key

I would expect keys would only play when actually pressing them, not when coming from a modifier key release.

@baconpaul
Copy link
Collaborator Author

Yeah so that’s because the widget scans the keyboard when there’s a change which is why chording and stuff works. And releasing alt makes it scan and see k is down. The midi keyboard is not a press api it is a scan on change api (roughly)

my guess is all of these will be very very hard to fix

@mkruselj
Copy link
Collaborator

😢

@baconpaul
Copy link
Collaborator Author

alt k doesn't work on macOS either
it and alt t both just give beeps
so the keyboard mapping is somehow not right even before we fix this.
hmm.

@baconpaul baconpaul added the Might Bounce Out Of Milestone Issues we think might not make it for official release, coming from the milestone we're working on label Dec 4, 2021
@mkruselj mkruselj removed the Might Bounce Out Of Milestone Issues we think might not make it for official release, coming from the milestone we're working on label Dec 4, 2021
@mkruselj
Copy link
Collaborator

mkruselj commented Dec 29, 2021

@baconpaul There is a potential workaround for this issue. Alt+K is the current shortcut (because K=keyboard). We could in theory modify it to be Alt+V (V=virtual keyboard?), perhaps. It's not very intuitive but it would sidestep this issue. Hmhmhmhm...

EDIT: It only sidesteps the issue partially... VKB is still blocked if a context menu is opened. Argh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Development

No branches or pull requests

2 participants