-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wavetable display will sometimes go "outside" it's limitations, clashing with the rest of the UI #532
Comments
this is what it looks like on Surge1.5.2 -- so, they always used to go above the limit. Looks weird. |
So looking at the code, it appears the toppling and bottom line are at 80% not 100% saturation. (COscillatorDisplay.h at line 47) This code just works by sampling the oscillator and drawing the output. That means these wavetables actually are getting very close to 1.0. Not quite sure what a fix would be. |
Still not sure what a fix is; I'm going to close this since I don't want to compress the display any further. |
I loaded the
Nick Moritz - PAD - Sorrowful
patch and put arrows where the wavetable actually goes outside of the UI limitations.The text was updated successfully, but these errors were encountered: