Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wavetable display will sometimes go "outside" it's limitations, clashing with the rest of the UI #532

Closed
esaruoho opened this issue Feb 7, 2019 · 6 comments

Comments

@esaruoho
Copy link
Collaborator

esaruoho commented Feb 7, 2019

I loaded the Nick Moritz - PAD - Sorrowful patch and put arrows where the wavetable actually goes outside of the UI limitations.

screenshot_07_02_2019__18_26

@esaruoho
Copy link
Collaborator Author

esaruoho commented Feb 7, 2019

same with Noisegeek - Rubberband Fight
screenshot_07_02_2019__18_30

@esaruoho
Copy link
Collaborator Author

esaruoho commented Feb 7, 2019

ZooZither - zzsurge_Elephantshok
image

@esaruoho
Copy link
Collaborator Author

esaruoho commented Feb 7, 2019

wavetable clipping occurring
wavetable clipping

@esaruoho
Copy link
Collaborator Author

esaruoho commented Feb 8, 2019

this is what it looks like on Surge1.5.2 -- so, they always used to go above the limit. Looks weird.
@kurasu is this "over-the-topness" designed so that it implies that the wavetable clips?

screenshot 2019-02-08 at 12 48 34

@baconpaul
Copy link
Collaborator

baconpaul commented Feb 8, 2019

So looking at the code, it appears the toppling and bottom line are at 80% not 100% saturation. (COscillatorDisplay.h at line 47)

This code just works by sampling the oscillator and drawing the output. That means these wavetables actually are getting very close to 1.0.

Not quite sure what a fix would be.

@baconpaul baconpaul added this to the 1.6.n milestone Mar 7, 2019
@baconpaul baconpaul modified the milestones: 1.6.n, Currently Unscheduled Oct 4, 2019
@baconpaul
Copy link
Collaborator

Still not sure what a fix is; I'm going to close this since I don't want to compress the display any further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants