Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formula Editor: indents not displayed #4925

Closed
ghost opened this issue Aug 27, 2021 · 9 comments
Closed

Formula Editor: indents not displayed #4925

ghost opened this issue Aug 27, 2021 · 9 comments
Labels
Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE
Milestone

Comments

@ghost
Copy link

ghost commented Aug 27, 2021

d83e03e
Linux Vst3 and Standalone

opening formula editor in Linux looks like this
form

  • When using TAB the cursor jumps 4 spaces to the right but the text does not.
  • Trying to delete "1" at the end of line 7 in the default example script
    deletes "2" instead (4 spaces to the left).

meaning TAB/indent is applied just not displayed correct.

@baconpaul baconpaul added this to the Surge XT 1.0 milestone Aug 27, 2021
@baconpaul
Copy link
Collaborator

OK yeah confirmed I see this on linux also at head.

@baconpaul
Copy link
Collaborator

OK confirmed this is a 6.0.8 -> 6.1 regression in JUCE

Let me hop to their forums and i will debug it this weekend if they don't have a response.

@baconpaul
Copy link
Collaborator

@mkruselj mkruselj added Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE Linux Issues which only occur on Linux labels Aug 27, 2021
@mkruselj
Copy link
Collaborator

Windows too.

@mkruselj mkruselj removed the Linux Issues which only occur on Linux label Aug 27, 2021
@mkruselj mkruselj changed the title Formula Editor: indents not displayed on Linux Formula Editor: indents not displayed Aug 27, 2021
@baconpaul
Copy link
Collaborator

So I've found the juce commit that breaks it and have a fix to that commit but i think that fix may break the thing it was trying to fix. But problem clearly identified.

@baconpaul
Copy link
Collaborator

baconpaul commented Aug 27, 2021

So lets see what JUCE team says but I can patch JUCE in one of a couple of ways (including this https://github.com/GavinRay97/JUCE-reaper-embedded-fx-gui/blob/master/cmake/patches.cmake) if they don't come back to me today or tomorrow.

@baconpaul
Copy link
Collaborator

I branched juce so this should be fixed at head.It is in my ubuntu vm. A confirm and I'll close it thanks.

Remember

(pull upstream as normal but then also)
git submodule sync
git submodule update --init --recursive
ls -l libs/JUCE/README.surge

should show a file before you build.

@ghost
Copy link
Author

ghost commented Aug 28, 2021

looks good on mint as well

@baconpaul
Copy link
Collaborator

Excellent. Let me close this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE
Projects
None yet
Development

No branches or pull requests

2 participants