Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickthrough in User Patch Submenu #4681

Closed
ghost opened this issue Jun 25, 2021 · 13 comments
Closed

Clickthrough in User Patch Submenu #4681

ghost opened this issue Jun 25, 2021 · 13 comments
Labels
Bug Report Item submitted using the Bug Report template Linux Issues which only occur on Linux Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone

Comments

@ghost
Copy link

ghost commented Jun 25, 2021

Linux 64bit
Standalone only
hash original post ccc1ad5
hash now 04e38b3

When selecting Patches (in the Patch Selector) that overlay the "Functions" part
of the menu, a click selects both the patch and the layer underneath.

This bug is best exposed in Mint with a Mate Desktop.
I aditionally tried xfce, cinnamon and stock ubuntu and can reproduce it in all of these,
it's just harder because the spots to click are much narrower which can make it seem random.

Example steps for Ubuntu:

  • Remove User Patches and Favorites
  • Select "Giana Brothers/Chords/5th Element"
  • Click exactly here (very small spot, try a few times):
    click
  • This will open a folder.

This is only one example, you can do this for all items in the functions menu.
Likewise in the FX menu.

Possible future bug reports that might be this:

  • Chorus Init(Dry) is a deadlink
  • Defaultpatch changes all the time
  • Selection hands out random patch
  • Selecting patch xyz crashes (super hard to reproduce but possible)
  • Patch selection opens folder/dialog/etc.
  • Selection triggers "initialize"
  • etc.

(btw: The license display mentioned below turns out to be a long standing Ubuntu issue, it's what they do)

@mkruselj mkruselj added Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. labels Jun 25, 2021
@mkruselj
Copy link
Collaborator

I take it this is using LV2, then?

@ghost
Copy link
Author

ghost commented Jun 25, 2021

no
standalone

@baconpaul
Copy link
Collaborator

Oooh that’s interesting
When you use the vst3 which daw are you using?
And what’s your Linux distro / wm if you don’t mind me asking

thank you!

@ghost
Copy link
Author

ghost commented Jun 25, 2021

host is reaper
distro is mint 20.1 / mate desktop

@baconpaul baconpaul added this to the Surge XT 1.0 milestone Jun 26, 2021
@baconpaul baconpaul added the Linux Issues which only occur on Linux label Jun 26, 2021
@mkruselj
Copy link
Collaborator

mkruselj commented Jul 6, 2021

Cannot confirm on Windows.

@baconpaul
Copy link
Collaborator

I tried ubuntu 20 reaper and also couldn’t confirm. Will need to come back to tbis one to debug this summer

@ghost
Copy link
Author

ghost commented Jul 6, 2021

:-)
This issue is about xt-standalone.
It is not happening with vst3 in Reaper and I did not try lv2.

I have now set up a fresh Ubuntu 20.04 LTS on the side
and installed the latest xt .deb to make sure it's not distro or build env specific
which by the way shows me this :)
Screenshot from 2021-07-06 18-25-05

and i can reproduce above described behavior with xt-standalone in ubuntu.

just to make sure we are all seeing the same:

  • Remove user patch folder for a second (so it doesn't show up in patch-browser)
  • Zoom 100%
  • Click on Third Party Patches/Bluelight/Percussion/Tubular
    -> Selects Tubular & opens file browser

I should add that the xt-alpha generally runs super nicely!
and as with all my reported issues, please understand this as:
FYI, look what I found, you might want to know this etc.

@mkruselj
Copy link
Collaborator

mkruselj commented Jul 6, 2021

I understood it's about standalone. I tested in XT standalone on Windows - doesn't happen.

@baconpaul
Copy link
Collaborator

Oh I should fix that license thing

ok when I next have a Linux vm running I will try. Greatly appreciate the clarity thank you

@ghost
Copy link
Author

ghost commented Jul 9, 2021

(removed confusing assumption)

@ghost
Copy link
Author

ghost commented Dec 9, 2021

I have edited first post with detailed reproduction steps for Ubuntu
(not to boost the importance but to get it out of my head without it getting lost,
I personally have a workaround)

@mkruselj
Copy link
Collaborator

@baconpaul It seems JUCE peoples nailed this one, if I understand the commit log correctly!

@baconpaul
Copy link
Collaborator

Yes it seems so!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template Linux Issues which only occur on Linux Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Development

No branches or pull requests

2 participants