Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Re-Structure some Overlays #4552

Closed
baconpaul opened this issue May 13, 2021 · 0 comments
Closed

Re-Re-Structure some Overlays #4552

baconpaul opened this issue May 13, 2021 · 0 comments
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme UI Issues related to UI look&feel
Milestone

Comments

@baconpaul
Copy link
Collaborator

The overlay mechanism is fine but there's some restructuring I would like to do to it

  1. Lets move the overlay functions to SurgeGUIEditorOverlays.cpp - SGE getting too big
  2. Rewrite the patch save dialog in juce. That would let us use juce::ComboBox for category also which brings Add menu list of all existing preset folders to Patch Store #1840 back from the dead (I think a save dialog outside the patch browser still makes perfect sense)
  3. Rework the open/close functions to be a bit more data driven. I worry that we don't actually need quite as much if-stuff in the open and recreate for instance. This will tie in tightly with the fix to XT Crash with overlay and FX select #4541 so lets do them simultaneously
@baconpaul baconpaul added Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. labels May 13, 2021
@baconpaul baconpaul added this to the Currently Unscheduled milestone May 13, 2021
@mkruselj mkruselj added UI Issues related to UI look&feel and removed UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. labels May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme UI Issues related to UI look&feel
Projects
None yet
Development

No branches or pull requests

2 participants