-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Surge GUI modulation 2019 coloring makes modulation difficult to see, and pitch slider ends vanish #428
Comments
modulation colouring also makes modulated sliders.. very difficult to see as a dark blue on a dark grey background.. the slider that is modulated almost dissapears from normal view.. |
I think this is fixable in the skin file. I’m curious though, what did this look like in the previous version? Or rather, is this a new issue or one that previously existed? Regardless, I’ll dig into it. I’m just curious if I’m trying to make it like the previous version or improve on it. |
I find it hard to say if it existed before or .. it's something i JUST noticed now .. when i was trying to make a patch.. i tend to think it didnt exist the same way it looks NOW .. than it did before when i made patches.. i only noticed it since building and using the latest master build. |
I’m on a phone right now but on my computer I’m making a bunch of changes to the skin. I’ll look into what this was like previously then figure out how to fix. If anyone has 1.5 installed it would be interesting to see what these states look like there. It’s a problem that should be addressed. I’m just trying to understand how. Nice catch BTW. |
I’m not sure what part is the problem but except for the green blink that’s all in the skins |
I have a this now. Could you take a look before sweeping? @baconpaul @sense-amr Cheers! |
Thoughts on the animated sliders? |
I haven’t quite followed the slider stuff so will leave that to you esa and sense. But in this screenshot I do notice
Don’t know if you know that or if those are separate issues but figured I’d mention it. I tried to get lato loading from the bundle on mac tonight. I failed. I’ll try and take another approach this weekend. I may fail again. But hey. We’ll see! |
Oh and: it looks great. I should have added that 👍 |
Thats definitely a lot easier to see @itsmedavep |
Also the orange background on the Scene buttons (for ‘split’ or whatever and ‘a’ ‘b’) have bitmapped not vectored corners. |
And it looks like the orange you use in the LFO drawing section is not exactly the original orange,since the LFO waveshape is a slightly different background. The color in the code is #FF9000 And that’s it, I promise! |
Thank you for capturing these comments! Ill endeavor to fix them all today. FWIW I don't believe I control the VU meter stuff in the skin file. Is the VU in question the Master Volume? @baconpaul I was aware of all of those things. I will fix. If were down to just 6 things with this its *much amaze super happy time!* Thank you everyone! |
Ok I will look at Vu this weekend |
@itsmedavep this ? |
Nice! Thank you. This seriously helps. A copy of 1.5.x would help too. lol. Im kind of flying blind over here WRT that. What would be really amazing, (and probably easiest) is if you could animate some of the vertical and horizontal sliders on all the various backgrounds. Then take a screen shot with the GUI zoomed up as high as you can get it. Add it here or send to me on Slack. Ive been contemplating adding something like that to the assets master directory. For posterity's (and my own sanity) sake. That would really really help me! Only time and inclination permitting, of course. Not trying to put you to work. Im getting started with all this now. Cheers! |
@itsmedavep i've sent you a video that Zvenx made, showing how Surge 1.52 works when it comes to showing "active modulation" and "latent modulation". hope it helps! |
Bummer. This one is a head scratcher right now. Ill revisit once I knock off more of the other issues. So the non color managed part of this may be the issue. My expectation would be that I would not see drift in a rendered file. Thats a visual artifact of not mapping to my display's color management (P3 Im just not sure how that would happen if the color value I'm using in the sketch file is the same as the one in the code. I eye dropper the the color value from the 1.5.2 bitmaps to use when setting up the source file. Anyone smarter than about this have an idea? Otherwise, spelunking I go! Leaving here for posterity. |
Oh I see you did that. |
Could you point me to where that code is being drawn? I have a couple of thoughts but nothing too concrete. Plus if I know the dims that are being drawn... I can put a border around it (ducks and leaves room). LOL. |
line 65 or so of CLFOGui.cpp but that code is ... hairy. Not obvious how the pixels are laid out. I'm actually looking at that for #354 right now. |
You know I could also make it transparent. |
Hmm transparent doesn't work sorry no. |
When I was doing a bit drawing in code for macOS I would specify the color space that I was using. [NSColor colorWithCalibratedRed: 0 green: 0 blue: 0 alpha: 1] or similar. Im curious about the draw code to see if there is something similar in the C++ that is drawing this stuff. Maybe thats off base, just my line of thinking. |
@sense-amr @baconpaul I updated the PR #437 now. I believe I have addressed all of the items brought up so far in this thread (with the exception of the orange LFO issue). |
@itsmedavep @esaruoho @baconpaul Screen 2 shows .. SLFO2 modulating SLFO 1 envelope and parameters Largest screen cap i can manage here.. Slider above Pan slider dissapeared.. Reverb ..
Also Uni Count .. not able to be modulated. |
Additionally a video showing animation of on off sates for automated paramaters.. Sorry i should state this is VST2 BITWIG 2.43 and Windows 10 .. |
@sense-amr If you check the Preset Bass->Mellow, the Pan Width appears. Not all presets utilize Pan Width. It is not gone, just disabled when the patch in Surge does not specifically ask for it. |
@sense-amr as per the manual at https://surge-synthesizer.github.io/manual/
|
this has been isolated into a separate case. #449 "Future Feature: Make Reverb: Pre-Delay,Room Shape,Size modulation with SLFO possible". there are also separate, related cases for future features. #316 , #233, #354, and #367. |
Hey guys - just checking I think Dave got all these things fixed right? Can we close this ticket and leave it to the other ones referenced in here? Or is there still something in the book of work? Thanks! |
I’m not aware of any further work needing to be done. It would be great if we could close this. |
OK I'll close it! If others disagree, lets either reopen it or open a new issue. Thanks @itsmedavep !!! |
@baconpaul |
one for @itsmedavep and @baconpaul maybe?
The text was updated successfully, but these errors were encountered: