Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack Traces in User Reporting #411

Closed
baconpaul opened this issue Jan 29, 2019 · 4 comments
Closed

Stack Traces in User Reporting #411

baconpaul opened this issue Jan 29, 2019 · 4 comments

Comments

@baconpaul
Copy link
Collaborator

Lots of times I find myself wanting a stack trace when I'm debugging. Enough times that I just want to make this something I don't have to hack in and hack out.

Anyone object if I add

std::vector<std::string> getCallStack()

to UserInformation and then add to promptError an appendCallStack = false option? @jsakkine would you reject that at review time before I code it up? :)

@jarkkojs
Copy link
Collaborator

No immediate objections. Just googled for ready made options.

Could we use https://github.com/boostorg/stacktrace? I mean it is a good idea, but do we want to maintain all the name mangling etc.?

@jarkkojs
Copy link
Collaborator

I'm not against adding, I'm more worried about maintaining one in the long run with all possible corner cases. That is why I'm thinking that if we want this, we should turn into 3rd party option.

@baconpaul
Copy link
Collaborator Author

Yeah mac has it built in with Xcode super easily. Maybe I will leave this out tho since windows definitely doesn't. I'll just c-n-p it in when I need to debug. I'm going to close this and not do it for now. Code already has enough complexity.

@baconpaul
Copy link
Collaborator Author

Thanks for reading tho!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants