Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story PolyCount in the Patch #4084

Closed
baconpaul opened this issue Mar 15, 2021 · 0 comments · Fixed by #4086
Closed

Story PolyCount in the Patch #4084

baconpaul opened this issue Mar 15, 2021 · 0 comments · Fixed by #4086
Milestone

Comments

@baconpaul
Copy link
Collaborator

baconpaul commented Mar 15, 2021

We should just do this, especially with twist requiring careful polycount to be CPU reasonable. So here's the plan

  1. Add a workflow switch "Use PolyCount from Patch" which defaults to True and associated menu
  2. Make SurgePatch stream it. Easy
  3. When SurgePatch unstreams it have the following semantic
    • Record the polycount going in
    • If the version is <= 15, at the end of the unstream, set the polycount to the prior version. (So if you set it to 6 then load a '15' patch it stays 6)
    • If the version is >= 16
      • If the patch has pollycount streamed (which it will for many but not the last month of nightlies) and the pref is set use it
      • If the patch doesn't have polycount streamed or if the pref is set false, use the prior version
  4. Close this and Store polyphony limit in patch #429 since this is a dup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant