Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Streaming should include a streaming format version number #391

Closed
baconpaul opened this issue Jan 26, 2019 · 1 comment
Closed

Patch Streaming should include a streaming format version number #391

baconpaul opened this issue Jan 26, 2019 · 1 comment
Labels
Feature Request New feature request

Comments

@baconpaul
Copy link
Collaborator

Folks got all excited about patch streaming changes this afternoon. I don’t know if any of that should happen. But I opened this issue to remind myself that

  1. Patches should stream a streaming format version number
  2. If they don’t we should make them start with “version 2” and no version number is ‘version 1”
  3. Then if we want to change things ever we aren’t quite as hosed
  4. Not clear we will ever get above a “version 2” if there is no version number.

If you’ve ever implemented an object database you know exactly what I mean. You know. That.

@baconpaul
Copy link
Collaborator Author

OK finally looking at this. And this is easy. There is a streaming number already. The XML starts with and so on. So closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature request
Projects
None yet
Development

No branches or pull requests

1 participant