Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./build-linux.sh #360

Closed
jarkkojs opened this issue Jan 20, 2019 · 8 comments
Closed

./build-linux.sh #360

jarkkojs opened this issue Jan 20, 2019 · 8 comments
Labels
Linux Issues which only occur on Linux

Comments

@jarkkojs
Copy link
Collaborator

Implement ./build-linux.sh that compiles Surge and copies configuration.xml, presets and wavetables to their locations.

@baconpaul
Copy link
Collaborator

Oh hey @jsakkine when you do the final sweep with your last step, can you also update README.md. @esaruoho did a first pass but getting it all ship shape for linux would be lovely. Thanks!

@jarkkojs
Copy link
Collaborator Author

@baconpaul, sure

@falkTX
Copy link
Contributor

falkTX commented Jan 21, 2019

For the linux builds, I really recommend updating vstgui to the latest version (which means your own vst3sdk repo, because vstgui is a submodule of this submodule..)

Current "stable" vstgui uses gtk3 for window and event management on Linux, which is pretty terrible.
It brings an entire big system toolkit for a plugin UI, which is supposed to be self-contained in the first place. (there are far too many reasons why gtk, or similar system/generic toolkits are bad ideas for plugins)
As it is, the plugin will fail to load (I mean, crash the host) when loaded in a few Linux hosts.

vstgui on its develop branch is going in the right direction, now using just cairo and xcb.

I got it built myself locally by using a slightly older git commit of vstgui (absolute latest has some API changes regarding menus that I did not look into).

@jarkkojs
Copy link
Collaborator Author

jarkkojs commented Jan 21, 2019

Switching to a newer VSTGUI is not an issue associated how we do Linux builds, or how we package. Lets not associate orthogonal problems with each other. I agree that getting rid of GTK would be nice, though.

@falkTX
Copy link
Contributor

falkTX commented Jan 21, 2019

I understand that this specific ticket is about the packaging.
It is still related a bit, because we will have to switch libraries used for linking.
I created the other ticket so we can leave updated-vstgui stuff there anyway.

Please note, if we do linux builds with the current state, it will be dangerous for users that try it.
Packaging as-is will result in a broken plugin.

@jarkkojs
Copy link
Collaborator Author

This not really a packaging issue, just a build script, and missing still presets and wavetables. Can you define what you mean by user? There is nothing too dangerous in that script, and it is not meant for end users.

@esaruoho
Copy link
Collaborator

esaruoho commented Feb 5, 2019

is the packaging finished or still under way? just wondering if this ticket can be closed or still under works? @jsakkine

@jarkkojs
Copy link
Collaborator Author

jarkkojs commented Feb 5, 2019

Can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Linux Issues which only occur on Linux
Projects
None yet
Development

No branches or pull requests

4 participants