Deal with the large number of clang-tidy warnings we get

[baconpaul]

Don't make em errors. But you know.
CLion in SGE shows hundreds of problems. Things like =0 or =NULL vs =nullptr are just good 1.9isms
Also make it so it is easy to run clang-tidy for non-clion users I guess!

[baconpaul]

On linux this is as easy as apply this diff

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 8d6796db..472d63a8 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -10,6 +10,7 @@ cmake_policy(SET CMP0091 NEW)
 set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")
 set(CMAKE_OSX_DEPLOYMENT_TARGET 10.9 CACHE STRING "Build for 10.9")
 set(CMAKE_POSITION_INDEPENDENT_CODE ON)
+set(CMAKE_CXX_CLANG_TIDY clang-tidy -checks=-*,readability-*,modernize-*)
 
 if(NOT CMAKE_BUILD_TYPE)
   set(CMAKE_BUILD_TYPE "Release" CACHE STRING "" FORCE)

cmake -Bclt 
cmake --build clt

and you see all the warnings - many of which we don't want

So basically curate that list and add it as a cmake option then voila