Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: automatic builds could use --date - improvement for ./make_installer.sh #292

Closed
esaruoho opened this issue Jan 12, 2019 · 3 comments

Comments

@esaruoho
Copy link
Collaborator

proposal, improve installer_mac/make_installer.sh by adding --date as a switch.

--date would be "$(date +%Y-%m-%d-%H-%M-%S)"

this way the built packager is called
Surge-2019-01-12-23-15-55-Setup.pkg

thoughts, @kzantow @baconpaul

...i think i heard some talk about wanting to have the date+time of build in the file itself.
would this help somehow?

@baconpaul
Copy link
Collaborator

As I said on slack, I think the right name is

Surge 1.6beta 20190112.dmg

or some such. We don't need the time But we do need that 1.6beta.

@baconpaul
Copy link
Collaborator

I don't want to put this in make-installer but there's a diff coming soon that will add it to build-osx so you get a one-step.

Basically

build-osx.sh --clean-and-package

cleans down everything and makes a package and puts in in product with a good name.

build-osx.sh --package

just runs the packaging.

@baconpaul
Copy link
Collaborator

Oh and so I closed this since it's going in build-osx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants