Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch SurgeError in the corresponding plugins (VST2, VST3, AU) #280

Closed
jarkkojs opened this issue Jan 12, 2019 · 6 comments
Closed

Catch SurgeError in the corresponding plugins (VST2, VST3, AU) #280

jarkkojs opened this issue Jan 12, 2019 · 6 comments
Labels
VST3 VST3 plugin related issues

Comments

@jarkkojs
Copy link
Collaborator

In order to get eventually rid of GUI code inside SurgeStorage.cpp, display error dialog in the plugin level by catching SurgeError exception.

@jarkkojs
Copy link
Collaborator Author

Probably more than one PR. I'm working in the VST2 side now.

@baconpaul
Copy link
Collaborator

See #217 also for a comment in what to do when you do catch

@baconpaul
Copy link
Collaborator

Just letting you know: I'm coding up #217 now and will sweep this in along with it. Will have a chunk of code for you to review in the next day or two.

@baconpaul
Copy link
Collaborator

So turns out that having the constructor throw in the audio unit is "relatively painful" if I don't want to segfault with the way the allayed is for now. So while I agree this is a great aspiration, I'm going to special case audio unit in surge storage for now to pop the dialog and complete the constructor. Just FYI.

Although I did learn something interesting about how AU hosts deal with mis initialitialization... but I'm going to hold on debugging and just wrap #217 for now.

@baconpaul
Copy link
Collaborator

OK actually this works pretty badly on VST2 Mac also. If the configuration.xml isn't there you get the message but then (say) bitwig forgets the plugin. I think this throw from the constructor is going to be generally unpleasant to handle on the mac hosts (from my sample size of 2 hosts and 2 plugin types). Something to discuss but I think this isn't easy to handle throwing constructor of the main type.

@esaruoho esaruoho added the VST3 VST3 plugin related issues label Jan 29, 2019
@jarkkojs
Copy link
Collaborator Author

I think things are now in sustainable state. Better to do smaller scale issues if need arises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VST3 VST3 plugin related issues
Projects
None yet
Development

No branches or pull requests

3 participants