post-automation-247 bug: a couple of buttons spew forth extra data

[esaruoho]

after @baconpaul 's automation-247 PR got merged in, here are a couple that spew forth excess automation parameters:

FX1 Return throws C1:-
FX2 Return throws C2:-
Master Volume throws C3:-

Split throws C5:-
Split Key throws C6:-
Poly Limit throws C8:-

and here's "and remind Paul to suppress events less than 0"

[baconpaul]

scene_active throws 4
fx_disable throws 7
from the code

Something is peculiar about C0->C8 and their parameter numbers which I can't figure out right now. Lets leave this one open for a bit.

[esaruoho]

will re-check these in a while.

[esaruoho]

yep, they're still here:

[esaruoho]

$ gg "Master Volume"
src/common/SurgePatch.cpp:          p_id++, 0, "volume", "Master Volume", ct_decibel_attenuation, hmargin + gui_sec_width * 5,
$ gg "FX1 Return"
src/common/SurgePatch.cpp:      param_ptr.push_back(fx[4].return_level.assign(p_id++, 0, "volume_FX1", "FX1 Return",
$ gg "FX2 Return"
src/common/SurgePatch.cpp:      param_ptr.push_back(fx[5].return_level.assign(p_id++, 0, "volume_FX2", "FX2 Return",
$ gg "Split Key"
src/common/SurgePatch.cpp:   param_ptr.push_back(splitkey.assign(p_id++, 0, "splitkey", "Split Key", ct_midikey, 8 + 91,
$ gg "Poly Limit"
src/common/SurgePatch.cpp:   param_ptr.push_back(polylimit.assign(p_id++, 0, "polylimit", "Poly Limit", ct_polylimit, 8 + 91,

okay.. so, how would i know for sure that it's SurgePatch.cpp that is throwing these extras?

[esaruoho]

Looks like this area is the culprit:

surge/src/common/SurgePatch.cpp

Lines 53 to 99 in 3f152b0

	this->storage = storage;
	patchptr = nullptr;
	int p_id = 0;
	{
	int px = gui_col6_x, py = gui_sendfx_y;
	param_ptr.push_back(fx[4].return_level.assign(p_id++, 0, "volume_FX1", "FX1 Return",
	ct_amplitude, px, py, 0, cg_GLOBAL, 0, true,
	VSTGUI::CSlider::kHorizontal));
	py += gui_hfader_dist;
	param_ptr.push_back(fx[5].return_level.assign(p_id++, 0, "volume_FX2", "FX2 Return",
	ct_amplitude, px, py, 0, cg_GLOBAL, 0, true,
	VSTGUI::CSlider::kHorizontal));
	py += gui_hfader_dist;
	// TODO don't store in the patch ?
	param_ptr.push_back(volume.assign(
	p_id++, 0, "volume", "Master Volume", ct_decibel_attenuation, hmargin + gui_sec_width * 5,
	gui_mid_topbar_y + 12, 0, cg_GLOBAL, 0, true, VSTGUI::CSlider::kHorizontal | kEasy));
	}
	param_ptr.push_back(scene_active.assign(p_id++, 0, "scene_active", "Active Scene", ct_scenesel,
	7, gui_mid_topbar_y - 2, 0, cg_GLOBAL, 0, false,
	VSTGUI::CSlider::kHorizontal));
	param_ptr.push_back(scenemode.assign(p_id++, 0, "scenemode", "Scene Mode", ct_scenemode,
	8 + 51 + 3, gui_mid_topbar_y - 2, 0, cg_GLOBAL, 0, false,
	VSTGUI::CSlider::kHorizontal | kNoPopup));
	// param_ptr.push_back(scenemorph.assign(p_id++,0,"scenemorph","scenemorph",ct_percent,hmargin+gui_sec_width,gui_mid_topbar_y,0,0,0,false,VSTGUI::CSlider::kHorizontal));
	param_ptr.push_back(splitkey.assign(p_id++, 0, "splitkey", "Split Key", ct_midikey, 8 + 91,
	gui_mid_topbar_y - 3, 0, cg_GLOBAL, 0, false,
	VSTGUI::CSlider::kHorizontal | kNoPopup));
	param_ptr.push_back(fx_disable.assign(p_id++, 0, "fx_disable", "FX Disable", ct_none, 0, 0, 0,
	cg_GLOBAL, 0, false));
	// shouldnt't be stored in the patch
	param_ptr.push_back(polylimit.assign(p_id++, 0, "polylimit", "Poly Limit", ct_polylimit, 8 + 91,
	gui_mid_topbar_y + 13, 0, cg_GLOBAL, 0, false,
	VSTGUI::CSlider::kHorizontal | kNoPopup));
	param_ptr.push_back(fx_bypass.assign(p_id++, 0, "fx_bypass", "FX Bypass", ct_fxbypass, 607,
	gui_mid_topbar_y - 6, 0, cg_GLOBAL, 0, false,
	VSTGUI::CSlider::kHorizontal | kNoPopup));
	polylimit.val.i = 8;
	splitkey.val.i = 60;
	volume.val.f = 0;

[esaruoho]

as a hint, @baconpaul fixed the previous "double-automation-spewings" by making these changes:
https://github.com/surge-synthesizer/surge/pull/262/files

[baconpaul]

yeah but this is a different problem of ids overlapping adjacent to that. I'm going to remove the good first issue label here; this one is tricky.

[lunafreya]

@esaruoho, @baconpaul, did you resolved the extra data problem for this issue? I think this might have been overlooked before the first stable 1.6 version was released.

[baconpaul]

Along the way this got resolved; probably by all the work I did in the VST3 and AU to make these controls appear. But confirming that the VST2 in Reaper no longer throws the extra controls.