Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging, releasing and immediately single-clicking resets slider to default #2302

Closed
VincyZed opened this issue Jul 6, 2020 · 4 comments
Closed
Labels
Bug Report Item submitted using the Bug Report template UI Issues related to UI look&feel
Milestone

Comments

@VincyZed
Copy link
Collaborator

VincyZed commented Jul 6, 2020

Describe the bug
Double-click is the gesture to reset a slider to default value in Surge. However, dragging, releasing and immediately single-clicking on it act as if it was a double-click, which in my case at least, leads to lots of unintended resets.

Version
Latest nightly, VST3, Windows 10.

Expected behavior
Dragging, releasing and clicking again should just make the slider draggable when moving the mouse again, instead of resetting to default value.

Additional information
I guess to fix this, we should check if mouse moved for both clicks in the double-click.

@VincyZed VincyZed added the Bug Report Item submitted using the Bug Report template label Jul 6, 2020
@baconpaul
Copy link
Collaborator

ugh - the double click is delivered by vstgui so this one has me fishing in there. I'm going to tag this for 1.7.n

Great bug report.

@baconpaul baconpaul added UI Issues related to UI look&feel VSTGUI labels Jul 6, 2020
@baconpaul baconpaul added this to the 1.7.n milestone Jul 6, 2020
@mkruselj
Copy link
Collaborator

@VincyZed I cannot seem to reproduce this anymore in current nightly... we could likely close it if you can confirm the same?

@VincyZed
Copy link
Collaborator Author

It still happens over here:
Mod

@mkruselj mkruselj modified the milestones: 1.8.n, 1.9.0 Oct 8, 2020
@VincyZed
Copy link
Collaborator Author

This doesn't happen anymore, probably since the cursor snapping and hiding changes, so we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template UI Issues related to UI look&feel
Projects
None yet
Development

No branches or pull requests

3 participants