Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Unicode Checks #2276

Closed
baconpaul opened this issue Jul 2, 2020 · 3 comments
Closed

More Unicode Checks #2276

baconpaul opened this issue Jul 2, 2020 · 3 comments
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme JUCE Ex Machina Issue that will likely be fixed by porting Surge to JUCE UI/plugin back-end
Milestone

Comments

@baconpaul
Copy link
Collaborator

defaultAuthor being garbage memory blew up linux over in #2266 and I fixed it with a small unicode check
we should be more fulsome with those since it seems vstgui type-ins are not very resilient under bad strings.

@baconpaul baconpaul added the Feature Request New feature request label Jul 2, 2020
@baconpaul baconpaul added this to the 1.7.n milestone Jul 2, 2020
@mkruselj mkruselj added Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme and removed Feature Request New feature request labels Jul 2, 2020
@mkruselj mkruselj modified the milestones: 1.8.n, 1.9.0 Oct 8, 2020
@mkruselj mkruselj modified the milestones: 1.9.0, Surge XT Jan 24, 2021
@mkruselj mkruselj added the JUCE Ex Machina Issue that will likely be fixed by porting Surge to JUCE UI/plugin back-end label Jan 27, 2021
@mkruselj
Copy link
Collaborator

@baconpaul Does this one need any attention for XT, still?

@baconpaul
Copy link
Collaborator Author

in a different way - wanna leave it open for a tiny but until i make sure i am fully utf8ified in juce

@baconpaul
Copy link
Collaborator Author

#4385 completely subsumes this. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme JUCE Ex Machina Issue that will likely be fixed by porting Surge to JUCE UI/plugin back-end
Projects
None yet
Development

No branches or pull requests

2 participants