Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio input display should draw incoming audio #2216

Closed
K0rrid0r opened this issue Jun 27, 2020 · 1 comment
Closed

Audio input display should draw incoming audio #2216

K0rrid0r opened this issue Jun 27, 2020 · 1 comment
Labels
Feature Request New feature request Oscillator Features or additions to the oscillator section UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.

Comments

@K0rrid0r
Copy link
Collaborator

K0rrid0r commented Jun 27, 2020

102

A change in SurgeGUIeditor.cpp and Oscillator.h allowed for osc_audioinput to start draw the incoming audio in the oscillator display in realtime. But it needs some work so let's toss it into 1.7.1

if( oscdisplay && synth->storage.getPatch().scene[current_scene].osc[current_osc].type.val.i == ot_audioinput ) {
oscdisplay->invalid();
}

Korridor 4:21 PM
Paul that worked really well! It's not perfect but worked!

baconpaul 4:21 PM
yeah
figured it would
hows your CPU when it is running though?

Korridor 4:22 PM
nothing changed in the cpu

baconpaul 4:22 PM
I would want to do some profiling and optimization if we merged that
this is exactly the kind of thing we dont want to put into 170 last minute
but that we do want to properly profile and test for 171

baconpaul 4:23 PM
this is the sort of thing that would splat some linux daw or break on macos 10.12 or something
so lets be conservative
but I am hopeful that a scope is entirely possible

@baconpaul baconpaul added this to the 1.7.n milestone Jun 27, 2020
@baconpaul baconpaul added Oscillator Features or additions to the oscillator section UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. labels Jun 27, 2020
@K0rrid0r K0rrid0r modified the milestones: 1.7.n, 1.7.2 Aug 27, 2020
@mkruselj mkruselj modified the milestones: 1.7.2, 1.7.n Sep 8, 2020
@mkruselj mkruselj modified the milestones: 1.8.n, 1.9.0 Oct 8, 2020
@mkruselj mkruselj changed the title Audioinput display should draw incoming audio Audio input display should draw incoming audio Oct 8, 2020
@mkruselj mkruselj added the Feature Request New feature request label Nov 9, 2020
@mkruselj mkruselj modified the milestones: 1.9.0, Surge XT Jan 24, 2021
@mkruselj
Copy link
Collaborator

Closing as duplicate of #1970.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature request Oscillator Features or additions to the oscillator section UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Development

No branches or pull requests

3 participants