Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake - make sure the VS default configuration is set to Release #2092

Closed
mkruselj opened this issue Jun 10, 2020 · 5 comments
Closed

cmake - make sure the VS default configuration is set to Release #2092

mkruselj opened this issue Jun 10, 2020 · 5 comments
Labels
Infrastructure Issues related to repository, CI/CD, installers, etc.

Comments

@mkruselj
Copy link
Collaborator

Instead of Debug.

@mkruselj mkruselj added the Infrastructure Issues related to repository, CI/CD, installers, etc. label Jun 10, 2020
@mkruselj mkruselj modified the milestones: 1.7.n, 1.7 beta 1 Jun 10, 2020
@baconpaul baconpaul modified the milestones: 1.7 beta 1, 1.7.n Jun 10, 2020
@baconpaul
Copy link
Collaborator

From googling I am not sure this is easy. Pushing it to 1.7.n. (the pipelines all explicitly set their config of course).

@baconpaul baconpaul changed the title cmake - make sure the VS configuration is set to Release cmake - make sure the VS default configuration is set to Release Jun 10, 2020
@baconpaul
Copy link
Collaborator

We can

set( CMAKE_CONFIGURATION_TYPES "Release" )

and then only Release is there. But if I set it to "Release;Debug" (so release is first) cmake still picks debug as the default for me in my test.

@mkruselj
Copy link
Collaborator Author

Do we really really need the debug one? I recall you saying they're not really that useful, for some reason or another.

@mvf
Copy link
Collaborator

mvf commented Oct 2, 2020

This can probably be closed.

Debug is a Visual Studio default, independent from CMake. It remembers the last-used solution configuration in its own (binary) .suo config file, which CMake doesn't generate. So indeed, the only way to make Visual Studio default to Release is removing the other build types. But with Debug builds starting to see some use lately, this doesn't seem feasible or even desirable anymore.

@baconpaul
Copy link
Collaborator

Agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues related to repository, CI/CD, installers, etc.
Projects
None yet
Development

No branches or pull requests

3 participants