Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preset menu checkmark not present on init #1896

Closed
mkruselj opened this issue May 15, 2020 · 2 comments
Closed

Preset menu checkmark not present on init #1896

mkruselj opened this issue May 15, 2020 · 2 comments
Labels
JUCE Ex Machina Issue that will likely be fixed by porting Surge to JUCE UI/plugin back-end UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented May 15, 2020

When you open Surge it loads its "init" state. When you now open the preset menu, you cannot see the checkmark on any category or preset (because there is no preset called just "init" - this seems closely related to issue #1814).

Now if you try to store a new patch, it does show its name in the menu, but doesn't add checkmark next to it, which makes no sense because the patch is already loaded.

BTW, the currently selected category doesn't get repositioned in the menu at all in this case either, so if you do this:

  1. load Surge
  2. save patch immediately under a different name
  3. click prev/next preset

...instead of going prev/next from the place where you have just saved the patch, it goes back to Bass folder first preset, Attacky.

Obviously this should all be more predictable, which is why I think we should start with an already existing init preset, so that both checkmarks and category focus are correct.

@mkruselj mkruselj added Code Hints Requested Someone would like to tackle this but wants a few pointers on how to start UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. labels May 15, 2020
@baconpaul baconpaul added this to the 1.7 beta 1 milestone May 25, 2020
@baconpaul
Copy link
Collaborator

This is related to #1824 also and we will have to fix both at the same time, so knocking this out of 1.7.b1 for now.

@baconpaul baconpaul modified the milestones: 1.7 beta 1, 1.7.n Jun 21, 2020
@mkruselj mkruselj modified the milestones: 1.7.n, 1.7.1 Jul 17, 2020
@mkruselj mkruselj modified the milestones: 1.7.1, 1.7.2 Jul 30, 2020
@mkruselj mkruselj modified the milestones: 1.7.2, 1.7.n Sep 8, 2020
@mkruselj mkruselj modified the milestones: 1.8.n, 1.9.0 Oct 8, 2020
@mkruselj mkruselj added the JUCE Ex Machina Issue that will likely be fixed by porting Surge to JUCE UI/plugin back-end label Jan 21, 2021
@mkruselj mkruselj modified the milestones: 1.9.0, Surge XT Jan 24, 2021
@baconpaul
Copy link
Collaborator

Oh I fixed this with my default push thingy last night also. Closing.

@mkruselj mkruselj removed the Code Hints Requested Someone would like to tackle this but wants a few pointers on how to start label Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JUCE Ex Machina Issue that will likely be fixed by porting Surge to JUCE UI/plugin back-end UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Development

No branches or pull requests

2 participants