Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stages parameter to Phaser #1706

Closed
mkruselj opened this issue Apr 11, 2020 · 3 comments
Closed

Add Stages parameter to Phaser #1706

mkruselj opened this issue Apr 11, 2020 · 3 comments
Labels
DSP Issues and feature requests related to sound generation in the synth Effects Feature Request New feature request

Comments

@mkruselj
Copy link
Collaborator

Presently, the phaser in Surge has 4 stages per channel (so 8 total). I could totally see the use for Stages parameter, that would be an integer between 2 and 12, to change the number of allpass filters used by the effect. Of course that means 4-24 stages total, for full stereo.

@mkruselj mkruselj added DSP Issues and feature requests related to sound generation in the synth Feature Request New feature request labels Apr 11, 2020
@baconpaul baconpaul added this to the 1.7 beta 1 milestone May 2, 2020
@baconpaul
Copy link
Collaborator

This is still a cool idea but I’m gonna knock it out if 17 beta 1

@mkruselj mkruselj modified the milestones: Currently Unscheduled, 1.7.n Jun 2, 2020
@mkruselj mkruselj modified the milestones: 1.7.n, 1.7.1 Jul 17, 2020
@mkruselj mkruselj modified the milestones: 1.7.1, 1.7.2 Jul 30, 2020
@mkruselj
Copy link
Collaborator Author

Thanks to @amyfurniss this is now a reality in the nightlies! It needs a bit more work to sound better (introducing legacy mode that keeps old 4 bands setup, but in new modes it should use the spread/distribution parameters to calculate the frequencies and modulation scaling per allpass.

@mkruselj
Copy link
Collaborator Author

mkruselj commented Nov 2, 2020

With #3015 this issue is now finally put to rest. Thank you @amyfurniss for being awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DSP Issues and feature requests related to sound generation in the synth Effects Feature Request New feature request
Projects
None yet
Development

No branches or pull requests

2 participants