Surge-VST2: build of macOSVST2 fails on current head

[esaruoho]

getting this with vst2 building on mac

Building surge-vst2 with output in build_logs/build_vst2.log
** BUILD FAILED **


The following build commands failed:
	CompileC /Users/esaruoho/work/surge/obj/x64/Release/surge-vst2/surge-vst2.build/Objects-normal/x86_64/audioeffect.o /Users/esaruoho/work/VST2.4SDK/public.sdk/source/vst2.x/audioeffect.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

** Build of vst2 failed**
CompileC /Users/esaruoho/work/surge/obj/x64/Release/surge-vst2/surge-vst2.build/Objects-normal/x86_64/tinyxmlerror.o /Users/esaruoho/work/surge/libs/xml/tinyxmlerror.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (in target: surge-vst2)
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x c++ -arch x86_64 -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -gmodules -Wno-trigraphs -fpascal-strings -O3 -Wno-missing-field-initializers -Wno-missing-prototypes -Wno-non-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparentheses -Wswitch -Wno-unused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wno-empty-body -Wno-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wno-constant-conversion -Wno-int-conversion -Wno-bool-conversion -Wno-enum-conversion -Wno-float-conversion -Wno-non-literal-null-conversion -Wno-objc-literal-conversion -Wno-shorten-64-to-32 -Wno-newline-eof -Wno-c++11-extensions -DVSTGUI_ENABLE_DEPRECATED_METHODS=0 -DDEBUG=0 -DRELEASE=1 -D_MM_ALIGN16=__attribute__((aligned(16))) -D_aligned_malloc(x,a)=malloc(x) -D_aligned_free(x)=free(x) -Dstricmp=strcasecmp -DSSE_VERSION=3 -DMAC_COCOA=1 -DCOCOA=1 -DOBJC_OLD_DISPATCH_PROTOTYPES=1 -DMAC=1 -DWINDOWS=0 -DTARGET_VST2=1 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -fasm-blocks -fstrict-aliasing -Wdeprecated-declarations -Winvalid-offsetof -mmacosx-version-min=10.14 -g -fvisibility-inlines-hidden -Wno-sign-conversion -Wno-infinite-recursion -Wno-move -Wno-comma -Wno-block-capture-autoreleasing -Wno-strict-prototypes -Wno-range-loop-analysis -Wno-semicolon-before-method-body -iquote /Users/esaruoho/work/surge/obj/x64/Release/surge-vst2/surge-vst2.build/Surge-generated-files.hmap -I/Users/esaruoho/work/surge/obj/x64/Release/surge-vst2/surge-vst2.build/Surge-own-target-headers.hmap -I/Users/esaruoho/work/surge/obj/x64/Release/surge-vst2/surge-vst2.build/Surge-all-target-headers.hmap -iquote /Users/esaruoho/work/surge/obj/x64/Release/surge-vst2/surge-vst2.build/Surge-project-headers.hmap -iquote libs/xml -iquote src/common/vt_dsp -iquote src/common/thread -iquote vst3sdk/vstgui4 -iquote vst3sdk -iquote libs -iquote src/common -iquote src/common/dsp -iquote src/common/gui -iquote src/mac -iquote src/vst2 -iquote ../VST2.4SDK -I/Users/esaruoho/work/surge/target/vst2/Release/include -Isrc/vst3 -Isrc/app -Isrc/vst2 -Isrc/todo -Isrc/mac -Isrc/common -Isrc/au -Isrc/windows -Isrc/common/util -Isrc/common/vt_dsp -Isrc/common/gui -Isrc/common/thread -Isrc/common/dsp -Isrc/common/dsp/effect -Ilibs/AUPublic -Ilibs/wtl -Ilibs/filesystem -Ilibs/xml -Ilibs/PublicUtility -Ivst3sdk/vstgui4 -I/Users/esaruoho/work/surge/obj/x64/Release/surge-vst2/surge-vst2.build/DerivedSources/x86_64 -I/Users/esaruoho/work/surge/obj/x64/Release/surge-vst2/surge-vst2.build/DerivedSources -F/Users/esaruoho/work/surge/target/vst2/Release -ffast-math -std=c++17 -stdlib=libc++ -DOBJC_OLD_DISPATCH_PROTOTYPES=1 -Wno-deprecated-declarations -Wno-inconsistent-missing-override -mmacosx-version-min=10.9 -Wno-unused-variable -include /Users/esaruoho/work/surge/obj/x64/Release/surge-vst2/SharedPrecompiledHeaders/SharedPrecompiledHeaders/2051853455734853179/precompiled.h -MMD -MT dependencies -MF /Users/esaruoho/work/surge/obj/x64/Release/surge-vst2/surge-vst2.build/Objects-normal/x86_64/tinyxmlerror.d --serialize-diagnostics /Users/esaruoho/work/surge/obj/x64/Release/surge-vst2/surge-vst2.build/Objects-normal/x86_64/tinyxmlerror.dia -c /Users/esaruoho/work/surge/libs/xml/tinyxmlerror.cpp -o /Users/esaruoho/work/surge/obj/x64/Release/surge-vst2/surge-vst2.build/Objects-normal/x86_64/tinyxmlerror.o
/Users/esaruoho/work/VST2.4SDK/public.sdk/source/vst2.x/audioeffect.cpp:512:20: error: non-constant-expression cannot be narrowed from type 'int' to 'char' in initializer list [-Wc++11-narrowing]
1 error generated.
    export GCC_TREAT_WARNINGS_AS_ERRORS=NO
    export TAPI_VERIFY_MODE=ErrorsOnly

Complete information is in build_logs/build_vst2.log

[esaruoho]

same result with today's (2 PRs were merged in) build.

[baconpaul]

Well, what's at line 512 of audioeffect.cpp?

[esaruoho]

no longer happens, closing ticket