Skin: Osc Wavefrom colors

[itsmedavep]

I didn't touch these in the dark skin but eventually it would be good to expose the ability to color the:

OSC waveform
Upper/lower limit of waveform drawing (the lines at the top and bottom)
OSC waveform bg color (the area the waveform draws on top of)

[baconpaul]

Although there's no way for you to know this at current other than reading the source, I actually did this in round one!

paul:~/dev/music/surge$ grep -r getColor src/common/gui/COscillatorDisplay.cpp 
src/common/gui/COscillatorDisplay.cpp:         dc->setFrameColor(skin->getColor( "osc.midline", VSTGUI::CColor(90, 90, 90)) );
src/common/gui/COscillatorDisplay.cpp:         dc->setFrameColor(skin->getColor( "osc.topline", VSTGUI::CColor(70, 70, 70)) );
src/common/gui/COscillatorDisplay.cpp:            dc->setFontColor(skin->getColor( "osc.label", kWhiteCColor) );
src/common/gui/COscillatorDisplay.cpp:         dc->setFrameColor(skin->getColor( "osc.wave", VSTGUI::CColor(0xFF, 0x90, 0, 0xFF)) );
src/common/gui/COscillatorDisplay.cpp:      VSTGUI::CColor fgcol = skin->getColor( "osc.wavename.background", VSTGUI::CColor( 0xff, 0xA0, 0x10, 0xff ) );
src/common/gui/COscillatorDisplay.cpp:      dc->setFontColor(skin->getColor( "osc.wavename.foreground", kBlackCColor) );

[baconpaul]

I added an issue to make this easier to discover and am going to close this one.