Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending Program Change and Notes at the same time yields a short pluck instead of preset #1601

Closed
hems opened this issue Feb 23, 2020 · 7 comments
Labels
Bug Report Item submitted using the Bug Report template MIDI MIDI support related

Comments

@hems
Copy link

hems commented Feb 23, 2020

Describe the bug
Sending Program Change on Ableton and Notes at the same time yields no sound, for instance:

image

^ will make no sound

image

^ if i delay the notes by 1/16 @ 121bpm will change the preset then yield sound.

Please let us know your surge version

I'm using the AU, here is the version / build screenshot
image

To Reproduce
Please look at bug description

Expected behavior
Change the preset and play the notes

Screenshots
please see description

Desktop (please complete the following information):

OSX 10.12.6, Abletn Live 10

@baconpaul
Copy link
Collaborator

Hi!

Let me tie this to #576. The way a program change will work is it will queue up a change so it is entirely possible that it comes out of order. Thank you for the report!

@baconpaul baconpaul added this to the Currently Unscheduled milestone Feb 23, 2020
@baconpaul baconpaul added the MIDI MIDI support related label Feb 23, 2020
@mkruselj mkruselj added the Bug Report Item submitted using the Bug Report template label Nov 9, 2020
@mkruselj mkruselj reopened this Nov 23, 2020
@mkruselj
Copy link
Collaborator

mkruselj commented Sep 21, 2021

When we get program change support working in the future (#576), we will test this, but we aren't fixing this code path, sorry. It will really depend on how JUCE implements this and how it schedules MIDI events internally. If behavior stays the same, well that's that then and nothing we can do about it, would need to be fixed on JUCE side (which is less likely to happen).

@mkruselj mkruselj removed this from the Currently Unscheduled milestone Sep 21, 2021
@hems
Copy link
Author

hems commented Sep 21, 2021

When we get program change support working in the future (#576), we will test this, but we aren't fixing this code path, sorry. It will really depend on how JUCE implements this and how it schedules MIDI events internally. If behavior stays the same, well that's that then and nothing we can do about it, would need to be fixed on JUCE side (which is less likely to happen).

so you saying every plugin made with JUCE has the same bug?

i find hard to think that would be the case? and if it's the case there must be some workaround documented JUCE forums / mailing list or something like that?

if there is not then we should fill a bug report on JUCE?

i honestly would like to help with with filling a bug or looking for the solution on the JUCE part ( surely someone has a solution for such basic issue ) but i'm not familiar enough with JUCE :(

@mkruselj
Copy link
Collaborator

mkruselj commented Sep 21, 2021

Try other JUCE plugins, i.e. OB-Xd or Dexed and see if they exhibit the same behavior.

In general, if a plugin receives a program change event AND a note event at literally the same MIDI tick, there's not enough time to load a new sound, initialize all the things, and play a voice. I see many (even non-JUCE) plugins not really working in this scenario. Your best bet is moving that first note a little bit so that it's not 100% on the grid.

@baconpaul
Copy link
Collaborator

No we aren’t saying that
We ported to juce and haven’t supported their preset mechanism yet
If this is fine in other juce plugins one day it will be in surge if we support their preset mechanism

@hems
Copy link
Author

hems commented Sep 21, 2021

Try other JUCE plugins, i.e. OB-Xd or Dexed and see if they exhibit the same behavior.

just tried on Dexed it works perfectly as expected

@hems
Copy link
Author

hems commented Sep 21, 2021

No we aren’t saying that
We ported to juce and haven’t supported their preset mechanism yet
If this is fine in other juce plugins one day it will be in surge if we support their preset mechanism

makes sense!! i understand @mkruselj message now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template MIDI MIDI support related
Projects
None yet
Development

No branches or pull requests

3 participants