Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegTest the FM changes #1564

Closed
baconpaul opened this issue Feb 12, 2020 · 2 comments
Closed

RegTest the FM changes #1564

baconpaul opened this issue Feb 12, 2020 · 2 comments
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme DSP Issues and feature requests related to sound generation in the synth

Comments

@baconpaul
Copy link
Collaborator

baconpaul commented Feb 12, 2020

With #1171 I made Window observe FM but I didn't add a retest with that commit just checked it by ear comparing Sin -> FM2 and Sin -> Window-Setup-As-Sin

Ideally we would check that the Pearson correlation between the two patches I used was similar as we modify FM depth. Or perhaps do a spectrum analysis to make sure similar high frequency spectra arise. Or maybe this is just too tricky to regtest automatically and reliably vs the size of the change, but I don't like that answer.

@baconpaul baconpaul added Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme DSP Issues and feature requests related to sound generation in the synth labels Feb 12, 2020
@baconpaul baconpaul added this to the 1.6.6 milestone Feb 12, 2020
@Jurek-Raben
Copy link

Hi, how about adding this for wavetable OSCs, too? Or let's say, making FM possible for any kind of OSC mode? What do you think about it?

@baconpaul
Copy link
Collaborator Author

baconpaul commented Feb 13, 2020

Right now, FM works on FM2/3/Sin/Window in one consistent manner and on Classic and Wavetable in a second manner, consistent with each other, but not consistent with the first chunk. The second is #1253 which is in the 1.6.6 milestone but, while trying to address yesterday, i realized may not be possible; so we may end up with two “clusters” of FM.

But right now all the oscillators (except maybe S&H) support FM just with rather different interpretations of depth in the two clusters.

EDIT: Confirmed that S&H works the same way as Classic and Wavetable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme DSP Issues and feature requests related to sound generation in the synth
Projects
None yet
Development

No branches or pull requests

3 participants