Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial patch loading (choose which scene from patch to load) #1420

Closed
oeai opened this issue Dec 15, 2019 · 6 comments
Closed

Partial patch loading (choose which scene from patch to load) #1420

oeai opened this issue Dec 15, 2019 · 6 comments
Labels
Design Required We need to design a solution to this issue Feature Request New feature request UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. Won't Be Done Issues we decided not to fix/implement, with good reasons behind. We'd welcome pull requests though!

Comments

@oeai
Copy link

oeai commented Dec 15, 2019

i'd like to change B scene with patch browser, when B is selected.

Now patch browser works only for A section and when you switch to B - it is always init0, so you have to find one patch - copy scene, then find next patch and paste previous patch scene to B.
I think that it is easier to just switch scenes and browse patches for each part then switch dual\split to hear thow it works.

@baconpaul
Copy link
Collaborator

Hi!

So I know exactly what you mean but it’s sort of not how surge works; we’ve talked about a variant before (and I thought it was a github issue but seems its not) so let me add that here.

A patch in surge contains both the A and B scene. For instance check out the “Lead with a bell attack” patch in MPE. So when you select scene B and open a patch, what it does is replace A with that patches A and B with that patches B.

The reason I think though you thought it did something else was that only about 5% of the factory patches use both scenes. So that gives you an implied behavior that “the patch loads in A and nothing loads in B” as opposed to what’s actually happening which is “the patch loads in A and B and this patch contains nothing in B”.

So the trick with loading “a patch in B” is there are a few shared things between scenes - namely the effects. The idea we discussed - which I think is the same thing you are thinking about - is if you are in Scene B you can load a patch either “into surge” (in which case you get the A and B and FX) or you can load “that patches A into my B” in which case that new patch scene A and scene A FX load into B, but the master FX, the sends, and the scene B from that patch are ignored.

Like I said we had chatted about that - I guess we talked on slack and didn’t make an issue - and your comment reminds me we should document it. But I also wanted to explain the current behavior for you!

Best

@baconpaul baconpaul changed the title Scene B - browse patches Load another pathches Scene A into Scene B Dec 15, 2019
@baconpaul baconpaul changed the title Load another pathches Scene A into Scene B Load another patches Scene A into Scene B Dec 15, 2019
@baconpaul baconpaul added this to the Currently Unscheduled milestone Dec 15, 2019
@oeai
Copy link
Author

oeai commented Dec 16, 2019

well i just want to get a more complex (fat) sound - i can try to make some changes with existing patch or i can find some additional sound with another patch, but i need to hear changes and i have to load another patch and copy previous. Maybe some "lock&load" button can help, so if i press it - it will not change A + FX or will not load\reset B patch.
But well if you've discussed before maybe you just have some better solution i guess.
Thanks.

@baconpaul
Copy link
Collaborator

Oh I think you mis understood my comment! Your idea is a good one, and we have no solution! Other than one basically like what you are imagining, which we had discussed. But which we haven’t coded! I was just trying to explain why nothing ever loads into B for you.

Partial patch load, patch compare, scene lock, load patch into B, undo, all those things would be fantastic, as would tackling a randomizer (where we do have an issue). It’s a good idea. But not one anyone is working on today.

Are you a C++ dev? If you would be interested in tackling any of these I would be happy to help get you oriented. Fine if not of course! But figured I would offer!

Thanks

@oeai
Copy link
Author

oeai commented Dec 16, 2019

i'm better with other no-coding stuff, it was java\c# years ago, so i don't know C++ really, but thanks.

@baconpaul
Copy link
Collaborator

OK figured I’d ask!

I am thinking about this one - and especially if I get #1413 done having a subset of this (which is a ‘load that patches A into my B’) may be super useful so let me link them. Obvious way to do that is to have the Scene B button RMB have a ‘load other patch scene A’ menu which opens the patch browser menu. Keep an eye on this issue - if i do it I’ll comment here.

@oeai
Copy link
Author

oeai commented Dec 16, 2019

ok, thanks

@mkruselj mkruselj changed the title Load another patches Scene A into Scene B Partial patch loading (choose which scene from patch to load) Feb 5, 2020
@mkruselj mkruselj added the UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. label Feb 5, 2020
@mkruselj mkruselj added the Feature Request New feature request label Nov 9, 2020
@mkruselj mkruselj added Design Required We need to design a solution to this issue Won't Be Done Issues we decided not to fix/implement, with good reasons behind. We'd welcome pull requests though! labels Sep 21, 2021
@mkruselj mkruselj removed this from the Currently Unscheduled milestone Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Required We need to design a solution to this issue Feature Request New feature request UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. Won't Be Done Issues we decided not to fix/implement, with good reasons behind. We'd welcome pull requests though!
Projects
None yet
Development

No branches or pull requests

3 participants