Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surge++ COscillatorDisplay color parameterization #1360

Closed
baconpaul opened this issue Dec 1, 2019 · 1 comment
Closed

Surge++ COscillatorDisplay color parameterization #1360

baconpaul opened this issue Dec 1, 2019 · 1 comment
Labels
UI Issues related to UI look&feel

Comments

@baconpaul
Copy link
Collaborator

Right now COscillatorDisplay (that draws the waveforms) hardcodes the colors.

If you look at LayoutEngineControlFactory.cpp you can see a block (search for "COscillatorDisplay") where the element is created by the control factory and an #if 0 surrounds the set colors

So ideally

  1. That #if 0 would be removed and the set colors would exist
  2. Then the actual widget (in src/common/GUI/COscillatorDIsplay) would use those colors
  3. And we would change the colors in the layout to test it

This is a good entry-to-the-codebase issue for S++

@baconpaul baconpaul added this to the Surge++ alpha 1 milestone Dec 1, 2019
@mkruselj mkruselj added UI Issues related to UI look&feel Layout engine labels Feb 5, 2020
@baconpaul
Copy link
Collaborator Author

Re-tooling the S++ plan so closing these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Issues related to UI look&feel
Projects
None yet
Development

No branches or pull requests

2 participants