Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surge++ Error Reporting could be better than stdout #1357

Closed
baconpaul opened this issue Dec 1, 2019 · 1 comment
Closed

Surge++ Error Reporting could be better than stdout #1357

baconpaul opened this issue Dec 1, 2019 · 1 comment
Labels
Experimental Issues related to experimental features that may or may not see the light of day

Comments

@baconpaul
Copy link
Collaborator

Right now Surge++ LayoutEngine has a LayoutLog::error() which adds things to stdout

We probably want to do something smarter than this; like push the collection of errors to the user in a popup at the end of a layout cycle and the end of a parse.

So make the little error() class keep a list of messages and in a couple of spots in SurgeGUIEditor (probably the LayoutEngine constructor and parser; and the openOrRecretateEditor) ask if there was an error and show it with UserInteractions::promptError() (for now).

@baconpaul baconpaul added the Experimental Issues related to experimental features that may or may not see the light of day label Dec 1, 2019
@baconpaul baconpaul added this to the Surge++ alpha 1 milestone Dec 1, 2019
@baconpaul
Copy link
Collaborator Author

Re-tooling the S++ plan so closing these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Experimental Issues related to experimental features that may or may not see the light of day
Projects
None yet
Development

No branches or pull requests

2 participants