Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to output build logs with build-osx.sh #132

Closed
kzantow opened this issue Dec 21, 2018 · 4 comments
Closed

Add flag to output build logs with build-osx.sh #132

kzantow opened this issue Dec 21, 2018 · 4 comments

Comments

@kzantow
Copy link
Collaborator

kzantow commented Dec 21, 2018

When building in CI, logs written to a file are lost when the VM terminates; it is much better to just output to terminal so results can be viewed. It would be fine to add a flag to make this behavior non-default.

Thoughts? Esp. @baconpaul

@baconpaul
Copy link
Collaborator

Easy enough to do. Also easy to do with an environment variable. Which do you prefer? Perhaps if you set a uniform ci build env var we can use that elsewhere too?

@kzantow
Copy link
Collaborator Author

kzantow commented Dec 21, 2018

I don't really have a preference, though I guess an environment variable would be the most consistent if there are scripts all over using across platforms. I'd like to see what the CMake stuff looks like #128 .

@baconpaul
Copy link
Collaborator

I just tossed in a PR which adds a --verbose flag. Check it out and if it works I'll merge it.

@baconpaul
Copy link
Collaborator

Thanks for testing the PR. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants