Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root of the Repo #121

Closed
baconpaul opened this issue Dec 20, 2018 · 2 comments
Closed

Root of the Repo #121

baconpaul opened this issue Dec 20, 2018 · 2 comments

Comments

@baconpaul
Copy link
Collaborator

baconpaul commented Dec 20, 2018

In #116 @asimilon said

I did think that maybe a good idea would be to clean up the root of the repo, and move any scripts into relevant sub-directories, eg:

kurasu/surge
  - scripts
    - windows
    - osx
    - linux

perhaps leaving the build scripts in the root would be a good idea though.
Originally posted by @asimilon in https://github.com/kurasu/surge/pull/116#issuecomment-448983103

and I said

Yeah I was thinking the same.

I was also thinking of making build-osx.sh a bit of a meatier script with functions and options. So you could do

./build-osx.sh # current behaviour
./build-osx.sh --install-local-au # basically what my install local au does
--install-local-vst
--install-local
--clean-builds
--remove-installs
--build-pkg
you get the idea. Then we can just add functions to that on switches. Easy enough.

so then I created this issue rather than talking about a change on a now merged and closed PR.

@baconpaul
Copy link
Collaborator Author

OK @asimilon said in the PR he liked the idea so I'll take a shot at it today. I'm tired of looking at vstgui and midi binary code so it will be a nice shift!

@baconpaul
Copy link
Collaborator Author

OK all merged. The mac stuff is now all ensconced in subdirectories with just a beefier build-osx.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant