From fa12ccb908bf4624a2a389e5bbc78f89cd64a4c8 Mon Sep 17 00:00:00 2001
From: Paul <baconpaul@users.noreply.github.com>
Date: Mon, 3 May 2021 21:31:59 -0400
Subject: [PATCH] Test the 'main' pipeline for XT (#4476)

1. Add a couple of consts to Parameter to make a change
2. Update the README
---
 README.md                | 12 ++++++++++--
 azure-pipelines.yml      | 11 +++--------
 src/common/Parameter.cpp |  4 ++--
 src/common/Parameter.h   |  4 ++--
 4 files changed, 17 insertions(+), 14 deletions(-)

diff --git a/README.md b/README.md
index 38a19f9ee7f..e884f20ef7a 100644
--- a/README.md
+++ b/README.md
@@ -1,5 +1,15 @@
 # Surge XT
 
+**If you are a musician looking to use Surge, please download the appropriate binary
+[from our website](https://surge-synthesizer.github.io). The Surge developer team makes regular releases for all supported platforms.**
+
+**If you are a developer looking to compile a stable production version of Surge, please do not
+use the main branch; instead use a release tag (such as `release_1.9.0`) or branch (such as
+`release/1.9.0`). Surge is undergoing substantial 
+development right now, and the `main` branch is currently an 
+incomplete alpha version for our fall 2021 release.**
+
+
 CI: [![CI Build Status](https://dev.azure.com/surge-synthesizer/surge/_apis/build/status/surge-synthesizer.surge?branchName=main)](https://dev.azure.com/surge-synthesizer/surge/_build/latest?definitionId=2&branchName=main)
 Release: [![Release Build Status](https://dev.azure.com/surge-synthesizer/surge/_apis/build/status/surge-synthesizer.releases?branchName=master)](https://dev.azure.com/surge-synthesizer/surge/_build/latest?definitionId=1&branchName=master)
 Release-XT: [![Release-XT Build Status](https://dev.azure.com/surge-synthesizer/surge/_apis/build/status/surge-synthesizer.releases-xt?branchName=master)](https://dev.azure.com/surge-synthesizer/surge/_build/latest?definitionId=13&branchName=master)
@@ -10,8 +20,6 @@ Claes chose to release a partially completed version of Surge 1.6 under GPL3, an
 of developers have been improving it since. You can learn more about the team at https://surge-synth-team.org/ or
 connect with us on [Discord](https://raw.githubusercontent.com/surge-synthesizer/surge-synthesizer.github.io/master/_includes/discord_invite_link).
 
-**If you are a musician only looking to use Surge, please download the appropriate binary
-[from our website](https://surge-synthesizer.github.io). The Surge developer team makes regular releases for all supported platforms.**
 
 If you would also like to participate in discussions, testing and design of Surge, we have
 details below and also in [the contributors section of the Surge website](https://surge-synthesizer.github.io/#contributors).
diff --git a/azure-pipelines.yml b/azure-pipelines.yml
index f6b95d4cf27..3e490e8eb7e 100644
--- a/azure-pipelines.yml
+++ b/azure-pipelines.yml
@@ -266,15 +266,10 @@ jobs:
       # remove refs/heads/
       export BRANCH="${BUILD_SOURCEBRANCH/refs\/heads\/}"
 
-      if [[ $BRANCH =~ ^xt-alpha$ ]]; then
-        echo "Launching the XT Release Build"
-        . $AGENT_TEMPDIRECTORY/notify-xt-releases.sh $BRANCH
+      if ! [[ $BRANCH =~ ^(main|release-xt/.+)$ ]]; then
         exit
       fi
 
-      if ! [[ $BRANCH =~ ^(main|release/.+)$ ]]; then
-        exit
-      fi
-
-      . $AGENT_TEMPDIRECTORY/notify-releases.sh $BRANCH
+      echo "Launching the XT Release Build"
+      . $AGENT_TEMPDIRECTORY/notify-xt-releases.sh $BRANCH
     displayName: Notify Releases
diff --git a/src/common/Parameter.cpp b/src/common/Parameter.cpp
index 4631799b8cc..d1bcc95bdb5 100644
--- a/src/common/Parameter.cpp
+++ b/src/common/Parameter.cpp
@@ -1771,9 +1771,9 @@ const char *Parameter::get_full_name()
     return fullname;
 }
 
-const char *Parameter::get_internal_name() { return name; }
+const char *Parameter::get_internal_name() const { return name; }
 
-const char *Parameter::get_storage_name() { return name_storage; }
+const char *Parameter::get_storage_name() const { return name_storage; }
 
 char *Parameter::get_storage_value(char *str)
 {
diff --git a/src/common/Parameter.h b/src/common/Parameter.h
index 341a5dcae24..f98b48fbb8a 100644
--- a/src/common/Parameter.h
+++ b/src/common/Parameter.h
@@ -381,8 +381,8 @@ class Parameter
     const char *get_name();
     const char *get_full_name();
     void set_name(const char *n); // never change name_storage as it is used for storage/recall
-    const char *get_internal_name();
-    const char *get_storage_name();
+    const char *get_internal_name() const;
+    const char *get_storage_name() const;
     const wchar_t *getUnit() const;
     void get_display(char *txt, bool external = false, float ef = 0.f);
     enum ModulationDisplayMode