Hide Param Typein on LastChance (#5510)

Closes #5506
surge-synthesizer · Nov 26, 2021 · 3e3c4d1 · 3e3c4d1
1 parent 1408e7c
commit 3e3c4d1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/src/surge-xt/gui/SurgeGUIEditor.cpp b/src/surge-xt/gui/SurgeGUIEditor.cpp
@@ -5622,6 +5622,8 @@ bool SurgeGUIEditor::isAHiddenSendOrReturn(Parameter *p)
     return false;
 }
 
+void SurgeGUIEditor::hideTypeinParamEditor() { typeinParamEditor->setVisible(false); }
+
 void SurgeGUIEditor::activateFromCurrentFx()
 {
     switch (current_fx)

diff --git a/src/surge-xt/gui/SurgeGUIEditor.h b/src/surge-xt/gui/SurgeGUIEditor.h
@@ -535,6 +535,7 @@ class SurgeGUIEditor : public Surge::GUI::IComponentTagValue::Listener,
     bool setParameterModulationFromString(Parameter *p, modsources ms, int modsourceScene,
                                           int modidx, const std::string &s);
     bool setControlFromString(modsources ms, const std::string &s);
+    void hideTypeinParamEditor();
     friend struct Surge::Overlays::TypeinParamEditor;
     friend struct Surge::Overlays::PatchStoreDialog;
     friend struct Surge::Widgets::MainFrame;

diff --git a/src/surge-xt/gui/widgets/MainFrame.cpp b/src/surge-xt/gui/widgets/MainFrame.cpp
@@ -37,6 +37,8 @@ void MainFrame::mouseDown(const juce::MouseEvent &event)
         return;
     }
 
+    editor->hideTypeinParamEditor();
+
     if (event.mods.isMiddleButtonDown())
     {
         editor->toggle_mod_editing();
-Original file line number
+Diff line change
@@ Expand Up / @@ -37,6 +37,8 @@ void MainFrame::mouseDown(const juce::MouseEvent &event) @@
             return;
         }
+        editor->hideTypeinParamEditor();
         if (event.mods.isMiddleButtonDown())
         {
             editor->toggle_mod_editing();
@@ Expand Down @@