Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

voice effect internal api should be tempo sync per param like the bus effects are #1334

Open
baconpaul opened this issue Sep 16, 2024 · 2 comments

Comments

@baconpaul
Copy link
Contributor

the way we tempo sync the lfo with envelope rate linear is what makes this hard.

@Andreya-Autumn
Copy link
Collaborator

One comment: I have been thinking that FXModControl maybe would work better for the voice-effects anyway, because of the smoothing it applies to the discontinuous shapes. I haven't looked at it enough to figure out how difficult that change would be. But if it would make this easier I could maybe do that first.

@baconpaul
Copy link
Contributor Author

That's really separate. The change here is temposyncRatio will get an index argument for the parameter is all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants