Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTS-ESP key displacement shenanigans #1306

Open
Andreya-Autumn opened this issue Sep 11, 2024 · 5 comments
Open

MTS-ESP key displacement shenanigans #1306

Andreya-Autumn opened this issue Sep 11, 2024 · 5 comments
Labels
Tuning Non-standard tuning extensions UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.

Comments

@Andreya-Autumn
Copy link
Collaborator

Andreya-Autumn commented Sep 11, 2024

The "Closest key" strategy is the general best choice for tuned sounds. But can cause some unexpected and weird behaviors in situations like "a single zone plays a tambourine sample". Think about it.

@Andreya-Autumn Andreya-Autumn added Bug Report Item submitted using the Bug Report template Tuning Non-standard tuning extensions UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. and removed Bug Report Item submitted using the Bug Report template labels Sep 11, 2024
@baconpaul
Copy link
Contributor

yeah for that you want the 'most original key biggest tune' as opposed to 'closest key smallest tune' strategy

or just use a bigger zone :)

@Andreya-Autumn
Copy link
Collaborator Author

I think the answer for drums is clearly "ignore MTS-ESP". And I reckon this would have to be per-part, for the probably not entirely hypothetical microtonal&multitimbral user base.

For tonal sounds, I have to do some more testing. In my test case where MTS-ESP retunes individual keys by more than a semitone, I found that the current strategy can make a key which has something mapped to it be entirely silent.

I see why that's happening. One zone doesn't have knowledge about all the other zones. So we play a different key and hope that that key has a zone on it (which is a reasonable replacement for the one played). When it doesn't you just get silence. I'm not sure it's the best we can do, but it sure is tricky.

@baconpaul
Copy link
Contributor

Right so is it zone(inbound key) or zone(closest frequency)? we will just need both modes.

@Andreya-Autumn
Copy link
Collaborator Author

Yeah both modes definitely.

But maybe also in the closest frequency case, we could try to guard against the "there's no zone there" somehow. Maybe the zone which is highest/lowest in a group could be allowed to retune further so you don't just get silence when you play a low or high note.

Then again, maybe the doctor simply prescribes "fix your zones". Thinking out loud here kinda.

Gonna do some testing some time and leaving this open for now.

@baconpaul
Copy link
Contributor

yeah my thought exactly was "you know you can edit zone boundaries in the UIright?" :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuning Non-standard tuning extensions UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Development

No branches or pull requests

2 participants