Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin state load is async #1157

Closed
baconpaul opened this issue Aug 19, 2024 · 0 comments · Fixed by #1160
Closed

Plugin state load is async #1157

baconpaul opened this issue Aug 19, 2024 · 0 comments · Fixed by #1160

Comments

@baconpaul
Copy link
Contributor

Nah I just need to have the engine post a semaphore when the unstream is done and wait in the clap

Talking with Xenakios the plugin returns from set state when the message is posted not when the engine is ready, which for command line and offline tenders and stuff is quite wrong
@baconpaul baconpaul mentioned this issue Aug 19, 2024
Open
baconpaul added a commit to baconpaul/shortcircuit-xt that referenced this issue Aug 20, 2024
@baconpaul
Async and Message Naming Rubric
8043059 
1. Make setState (which sends an UpdatEngine to the serialization
   thread) wait for the unstream to complete to correctly
   meet the plugin api requirement of synchronous set state.
   Closes surge-synthesizer#1157

2. Add a rubric for how message names should be set, and start
   a few, but not many. Addresses surge-synthesizer#1141. Did a partial merge since
   I had started but the new name had only been applied to set engine
   state and didn't want conflict pain in the future.
@baconpaul baconpaul mentioned this issue Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Async and Message Naming Rubric baconpaul/shortcircuit-xt
1 participant
@baconpaul