Add LG/SM cTime thresholds for prehop prevention #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dPexxIAM
reviewed
Aug 18, 2021
There was a problem hiding this comment.
seems fine, thanks! although i think you forgot about https://github.com/surftimer/Surftimer-Official/blob/b6a71e9ebde21cb865464c932de116baec199bf6/addons/sourcemod/scripting/surftimer/hooks.sp#L1351
|
@dPexxIAM It appears I have, I'll add LG/SM thresholds for that later |
dPexxIAM
approved these changes
Sep 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured out a way to extend the existing pre-hop prevention to accommodate the slower styles (Low-Gravity and Slow-Motion) by adding cTime thresholds that meet the style's requirements when checking for whether a player is currently in a bhop.
I initially tried re-working the system in agreement with sneaK's comment that the current system is pretty bad, but I ended up just giving up and trying to extend the current system. Until we get a full re-work, this should prevent pre-hopping in both Low-Gravity and Slow-Motion.
cTime Measurements:
