You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However put_message aggregates records into batches. This means that we might lose access to LSNs that have not been written to Kinesis yet if we crash before writing or during writing the batch.
I think we should only send feedback after the entire batch has been written?
The text was updated successfully, but these errors were encountered:
We seem to call
send_feedback
imemdiately afterself.writer.put_message
https://github.com/surbas/pg2kinesis/blob/master/pg2kinesis/__main__.py#L103
However
put_message
aggregates records into batches. This means that we might lose access to LSNs that have not been written to Kinesis yet if we crash before writing or during writing the batch.I think we should only send feedback after the entire batch has been written?
The text was updated successfully, but these errors were encountered: