-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust bindings: add typical impls #12
Comments
Don't be so sure:-) PR is welcomed! |
Closing the issue since the merged PR resolved it |
Any reason why |
Formally speaking this is not exactly a right place to pop such a question. As we are not considering ourselves as a "Rust shop." We do exercise, and one might even say advocate for minimally-required principle though. Taking this question as an example. You are not supposed to use your secret key for anything but signing, so why would it require a comparison trait? One can make a legitimate case against attaching generic traits as they make no commitments to constant-time execution, while blst does... |
Thanks again for this great library!
When implementing
blst
in Lighthouse (Eth2 impl) I noticed that the core structs (e.g.,PublicKey
,Signature
, etc) are missing some typical and useful impls. In particular:Clone
PartialEq
Eq
(if it adheres to the definition here)As you can see in our code, I've added some wrapper structs to Lighthouse and made my own custom implementations. It would be great if these were included in the library by default.
If the implementations I've used (see previous link) are good, I'm happy to make a PR to this repository. However I suspect that you might know faster or more elegant ways to achieve these things.
The text was updated successfully, but these errors were encountered: