Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for automatic protocol detection for most common service meshes #186

Closed
PeteMac88 opened this issue Oct 16, 2023 · 2 comments · Fixed by #185
Closed

Add support for automatic protocol detection for most common service meshes #186

PeteMac88 opened this issue Oct 16, 2023 · 2 comments · Fixed by #185
Assignees

Comments

@PeteMac88
Copy link
Contributor

Add support for automatic protocol detection for the ports provided by the service resource for service meshes like istio or kong. This can normally be done by adding the appProtocol field to the ports in the service or prefixing the service ports name with the protocol.

I created a PR to add the field see https://github.com/memphisdev/memphis-k8s/pull/185

@PeteMac88
Copy link
Contributor Author

@bkochauri-memphis Can you close the issue after the new chart version is deployed?

@bkochauri-memphis
Copy link
Contributor

Hi @PeteMac88 , I am closing the issue as a new version of helm chart was released.
Thank you for your contribution to memphis project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants