Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SuperEditor] - Composer preferences needs to change its notifier behavior to match Editable expectations #2362

Open
matthew-carroll opened this issue Oct 4, 2024 · 0 comments
Open

[SuperEditor] - Composer preferences needs to change its notifier behavior to match Editable expectations #2362

matthew-carroll opened this issue Oct 4, 2024 · 0 comments
Labels
area_supereditor Pertains to SuperEditor bounty_junior time:2

Comments

@matthew-carroll
Copy link
Contributor

Currently the ComposerPreferences inside of MutableDocumentComposer has its own ChangeNotifier implementation.

This is a problem because the entire MutableDocumentComposer is an Editable, and therefore should be pausing and resuming all change notifications based on the Editor pipeline.

Update the composer preferences to pause and resume notifications as needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area_supereditor Pertains to SuperEditor bounty_junior time:2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matthew-carroll