Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

Use nice, unobtrusive GitHub-styled icon as button #4

Merged
merged 3 commits into from
Sep 10, 2021
Merged

Use nice, unobtrusive GitHub-styled icon as button #4

merged 3 commits into from
Sep 10, 2021

Conversation

Cito
Copy link
Collaborator

@Cito Cito commented Sep 1, 2021

Includes the following changes:

  • text buttons replaced with icons
  • darker color while inactive for less distraction
  • also hide button until hovering over code block
  • fix TypeScript issues
  • use SCSS to simplify CSS

This is essentially jdbrice/obsidian-code-block-copy#13.

Thanks to @tdharris for the improvements.

@Cito
Use nice, unobtrusive GitHub-styled icon as button
d199698 
Includes the following changes:

- text buttons replaced with icons
- darker color while inactive for less distraction
- also hide button until hovering over code block
- fix TypeScript issues
- use SCSS to simplify CSS

This is essentially jdbrice/obsidian-code-block-copy#13.
@Cito Cito mentioned this pull request Sep 1, 2021
Open
@superDuperCyberTechno
Copy link
Owner

I'll have a look-see, ASAP. Thanks for the work.

@superDuperCyberTechno
Copy link
Owner

What exactly are the TypeScript issues? As far as I can tell it's only the indentation?

@Cito
Copy link
Collaborator Author

Cito commented Sep 2, 2021

What exactly are the TypeScript issues? As far as I can tell it's only the indentation?

Some variables like pre had no type, so my IDE and the build process warned when accessing certain properties. I have type casted it to the proper HTML element, so that these errors disappear.

@Cito
Copy link
Collaborator Author

Cito commented Sep 2, 2021

Regarding the indentation, I have formatted everything with prettier. Sorry, this should have been done separately.

@superDuperCyberTechno
Copy link
Owner

Regarding the indentation, I have formatted everything with prettier. Sorry, this should have been done separately.

No problem. I'm just lazy, haven't bothered with setting up proper JS indentation. Just went with the default 4 spaces. I'll look into making Vim behave so this doesn't become a recurring PR...

@superDuperCyberTechno superDuperCyberTechno merged commit dc79357 into superDuperCyberTechno:master Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cito @superDuperCyberTechno