Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser history stack is modified when time travelling #36

Open
supasate opened this issue Feb 19, 2017 · 0 comments
Open

Browser history stack is modified when time travelling #36

supasate opened this issue Feb 19, 2017 · 0 comments

Comments

@supasate
Copy link
Owner

Currently, when we do time travelling, the ConnectedRouter tries to change the URL bar to match the router state in the redux store (which is changed by Redux DevTools) by using history.push (see here).

This method seems to work fine, however, internally, the real browser history stack is modified (new history is pushed on top of the stack). It would be better if we can change the URL by just moving the pointer in the history stack to match time travelling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant